Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded prisoner transport bus #51649

Closed
wants to merge 10 commits into from
Closed

Conversation

faefux
Copy link
Contributor

@faefux faefux commented Sep 15, 2021

Summary

Content "Upgraded Prisoner Transport Bus"

Purpose of change

Number 2 in adding and upgrading some vehicles. I decided the prison bus didn't look very much like even an aproximation of a meat weagon, instead seemingly just a regular bus with contraband on.

Describe the solution

  • Added a separate sealed compartment for driver and guards with extra seats, including a reclining chair for sleeping.
  • Added a firearms lock-box in the guards compartment that spawns guns and ammo. (need help with this)
  • Gave the prisoner compartment it's own entrance.
  • Changed seating to the metal benches with shackles I added for pull Prisoner transport van #51645 (prisoner transport van)
  • Removed contraband as it seems very unlikely you are sneaking contraband of any nature on to a sweat box (let alone some of the things in the list.) without plugging it, so unless everyone had chronic diarrhea the last time the vehicle was used..

Describe alternatives you've considered

Remaking it from ground up, making it wider to be more faithful to the images I have seen.
Using a different design as there are many, I have no idea which is more prevalent IRL.

Testing

Tested on old install. Looks fine.

Additional context

I would have liked to add more guns in the box but when trying to add specifically , "count": [ 1, 3 ] to the below line this is incorrect. Could someone advice what I should be using here instead?
"items": [ { "x": 0, "y": 1, "chance": 70, "magazine": 100, "ammo": 50, "item_groups": [ "guns_cop" ] , "count": [ 1, 3 ] } ]

Images:
image
Above: The kind of bus I based it on. But I did not want to add a new set of plastic chairs so instead used to steel.
image
Above: A screenshot of the new version of the bus.

@faefux faefux marked this pull request as draft September 15, 2021 18:27
@faefux
Copy link
Contributor Author

faefux commented Sep 15, 2021

Set as Draft. It makes things to messy unless I wait until #51645 is merged, I think.

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. labels Sep 15, 2021
@anothersimulacrum anothersimulacrum removed Game: Balance Balancing of (existing) in-game features. <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 15, 2021
@actual-nh actual-nh added the Vehicles Vehicles, parts, mechanics & interactions label Sep 15, 2021
faefux and others added 2 commits September 16, 2021 15:19
@faefux faefux marked this pull request as ready for review September 18, 2021 12:55
faefux and others added 3 commits September 18, 2021 13:59
…ally how often do you see a meatwagon driving around town? They usually go from police station to court to jail once a day, at least in my experience.
No idea WTF that was.
@faefux
Copy link
Contributor Author

faefux commented Sep 18, 2021

Feel like something has gone horribly wrong here. No idea what.
Github is a giant pain in the ass that constantly throws a huge spanner in the works of uploading very simple and easy things.. turning putting a few lines of simple json up into a nightmare of file weirdness and breaking everything that works absolutely fine before upload. It shouldn't go this wrong every time. I have no idea why the van is in here despite it being a separate fucking PR. I hate this website and just want others to enjoy the things i make in the game i enjoy. Reeeeeee---

@@ -31,6 +31,10 @@
[ "policesuv_k9", 5 ],
[ "police_k9tpt", 1 ],
[ "truck_swat", 200 ],
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have literally no idea.. This is wht I never upload larger projects, sigh. Any advice on fixing this so I dont have to upload as a whole new branch or disregard?

@faefux faefux closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants