Weakpoints (Part 4): Add support for damage and crit multipliers

[Joshua-Chin]

Summary

Features "Add support for weak point damage and crit multipliers"

Purpose of change

Let contributors specify damage and crit multipliers for weak points.

Describe the solution

Add the damage_mult and crit_mult fields to the weak point object. The damage_mult is applied to the after-armor damage instance. If specified, the crit_mult field is used in place of the damage_mult field when the attacker crits.

As part of this change, we wire critical hit information from melee attacks and projectile attacks into the weakpoint_attack struct.

Describe alternatives you've considered

Testing

CI :)

Additional context

#51305

[I-am-Erk]

Well, I guess this will pretty much make headshots in Dark Days of the Dead possible.

Can you do a crit_mult as well to reduce or increase critical hit damage on a weakpoint?

[Joshua-Chin]

Can you do a crit_mult as well to reduce or increase critical hit damage on a weakpoint?

I'll need to modify the wiring slightly. The weakpoint_attack struct is passed around as const& and generated at the start of a successful attack. Critical hit determination is handled in an intermediate step (for ranged attacks, to handle "HARD_TO_HIT") and can't modify the struct.

I'd prefer to handle it in a follow-up PR (Part 4.5).

[I-am-Erk]

Should update to latest master to fix that martial arts bug

[Joshua-Chin]

Having separate features in the same PR was confusing. I moved the damage and critical multipliers to this PR and migrated the inheritance and default to the other one.