Fix mod testing in CI #51843
Merged
Fix mod testing in CI #51843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2021
Maleclypse
added
Code: Tests
jbytheway
force-pushed
the
restore_mod_checking_in_ci
branch
2 times, most recently
from
394bc38 to
d8d7a97
Compare
The conversion of the tests to use GNU parallel broke the testing of JSON data for mods other than Magiclysm. Refactor the code to fix that.
The fallback magazine selection code had a typo which meant that it was unable to choose any magazine type except the first listed. Fix it. Also improve the error message.
jbytheway
force-pushed
the
restore_mod_checking_in_ci
branch
from
d8d7a97 to
2557acf
Compare
jbytheway
requested review from
John-Candlebury,
Maleclypse and
Mom-Bun
as code owners
|
CI is all green, so marking ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The conversion of the tests to use GNU parallel broke the testing of JSON data for mods other than Magiclysm.
Describe the solution
Refactor the code to fix that.
I'm expecting to need to fix some errors in mods too, as a result of this, so opening as draft initially.
Describe alternatives you've considered
Living in blissful ignorance of mod issues.
Testing
Expecting to test here on CI.
Additional context