Upgraded prisoner transport bus #51891
Conversation
reeeeeee-
| @@ -1791,21 +1789,8 @@ | |||
| { "x": -8, "y": 3, "part": "plating_steel" } | |||
| ], | |||
| "items": [ | |||
| { "x": -1, "y": 0, "chance": 7, "item_groups": [ "contraband" ] }, | |||
| { "x": 0, "y": 0, "chance": 20, "items": [ "id_science_transport_1" ] }, | |||
There was a problem hiding this comment.
Why delete the science ID chance? This was added just a month ago to give some ways to legally enter the new labs.
There was a problem hiding this comment.
Specifically this one would be considered to be on one of the guards as these prisoners were being rerouted for experimentation.
{ "x": 0, "y": 0, "chance": 20, "items": [ "id_science_transport_1" ] },
There was a problem hiding this comment.
I'll give it the same chance of spawning except in the front compartment somewhere if that's okay with you guys. :)
There was a problem hiding this comment.
It sounds fine to me!
There was a problem hiding this comment.
Added it to the box in the front cabin, @Termineitor244, as well as in the same spot on the prison van but with a smaller chance of spawning. I feel those boxes should both be lock boxes really, (so behind a lockpicking skill-check, i guess) but would this make the card not accessible enough?
There was a problem hiding this comment.
It would be even better if its behind a lock! It would give even more of a sense of "This is something important, I should keep it with me". And a few locks are never enough deterrent for an experienced player.
BrettDong
added
[JSON]
| @@ -1791,21 +1789,8 @@ | |||
| { "x": -8, "y": 3, "part": "plating_steel" } | |||
| ], | |||
| "items": [ | |||
| { "x": -1, "y": 0, "chance": 7, "item_groups": [ "contraband" ] }, | |||
| { "x": 0, "y": 0, "chance": 20, "items": [ "id_science_transport_1" ] }, | |||
There was a problem hiding this comment.
| { "x": 0, "y": 0, "chance": 20, "items": [ "id_science_transport_1" ] }, | |
| { "x": 0, "y": 0, "chance": 20, "items": [ "id_science_transport_1" ] }, |
|
Let me know once you are ready for review? |
…asing. Ironically almost forgot the original reason I even considered a public PR for them both!
There you go, @Maleclypse , sorry I take so long and thank you for being patient with my multiple git-fails. :) |
|
sigh I'll give this thing one more chance if someone can show me where exactly there is an issue here is with the failing check. reeeee- :(. |
|
The failing test is not actually your problem, this looks good to go with a final review. |
Ah, sorry for whining so then, I am used to it being otherwise. Merci!
Appreciated, its just a small little thing. :) Hopefully I will improve at this to upload some larger more fun and cool things eventually! :) |
Summary
Content "Upgraded Prisoner Transport Bus"
Purpose of change
Number 2 in adding and upgrading some vehicles. I decided the prison bus didn't look very much like even an aproximation of a meat weagon, instead seemingly just a regular bus with contraband on.
Describe the solution
Describe alternatives you've considered
Remaking it from ground up, making it wider to be more faithful to the images I have seen.
Using a different design as there are many, I have no idea which is more prevalent IRL.
Testing
Tested on old install. Looks fine.
Additional context
I would have liked to add more guns in the box but when trying to add specifically
, "count": [ 1, 3 ]to the below line this is incorrect. Could someone advice what I should be using here instead?"items": [ { "x": 0, "y": 1, "chance": 70, "magazine": 100, "ammo": 50, "item_groups": [ "guns_cop" ] , "count": [ 1, 3 ] } ]Images:
Above: The kind of bus I based it on. But I did not want to add a new set of plastic chairs so instead used to steel.
Above: A screenshot of the new version of the bus.