Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mansion Scenario #51975

Closed
wants to merge 372 commits into from
Closed

Conversation

Termineitor244
Copy link
Contributor

Summary

Content "Adds a new scenario for starting in a mansion"

Purpose of change

Someone on reddit reminded me of an old mod that added a mansion scenario, I searched it and it was removed because it became obsolete... But you still can't start the game in a mansion! With the mansions basecamps and the good loot and roleplaying related to mansions, I think there is enough reason to add one.

Describe the solution

Adds a new mansion scenario, inspired by the one in Classes and Scenarios Mod, but with a different description and more professions (And it works now).

Describe alternatives you've considered

Adding more options for where to start in the mansion, like the basement or the upper floor, or even the Panic Room! But for now this is enough.
I also contemplated to simply add mansions as a possible location for the "Big Building" scenario, but scenarios are too cool for that.

Testing

I spawned several times in a mansion without problems, looked around, killed some zombies, and died at the hands of the old staff of the mansion!

Additional context

imagen
imagen
imagen

@ZhilkinSerg
Copy link
Contributor

New scenarios should really do something more interesting than simply allowing player character to start at specific location, e.g.:

@Termineitor244
Copy link
Contributor Author

New scenarios should really do something more interesting than simply allowing player character to start at specific location, e.g.:

* add custom start mission ([ Add new starting scenario The Last Delivery  #39703](https://github.com/CleverRaven/Cataclysm-DDA/pull/39703));

* use custom surround group ([Allow custom surround monster groups in scenarios #47990](https://github.com/CleverRaven/Cataclysm-DDA/pull/47990));

* use power of eocs ([Scenario specific effects on condition #50934](https://github.com/CleverRaven/Cataclysm-DDA/pull/50934)).

I could do a custom surround group for the scenario... Maybe some eocs, missions... I don't have ideas for one, but lets see what happens.

I will put the PR in draft while I do these changes then.

@Termineitor244 Termineitor244 marked this pull request as draft September 29, 2021 21:34
@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios labels Sep 29, 2021
@Maleclypse
Copy link
Member

Might I suggest the movie Ready or Not (2019 film) for some possible inspiration?

@Termineitor244
Copy link
Contributor Author

Ready or Not

I had something completely different (and more simple) in mind, but hahaha, after reading the wikipedia article of the movie, I think I want some new mansion ferals to start surrounding you in this scenario, and a new mission to survive until next day, I will give it a try and see what comes out of it, thanks for the idea!

@Termineitor244
Copy link
Contributor Author

Termineitor244 commented Sep 30, 2021

I added new ferals, the only really dangerous are the one with the crossbow and the real rapier, but they should give even more uniqueness to mansions, I will add them as a rare spawn to the monstergroups of mansions too, and the fancy ones will have a greater possibility in the spawn for the panic room (Makes sense).

I tried adding a mission to survive for the day, but it doesn't seems to be working... It doesn't finish after 1, 2 or 3 days, I'm not sure why.

I want to write a different description for the scenario "you were in a mansion, playing hide and seek with the staff/owners, and suddenly they are trying to kill you whenever they found you" something like that, but I haven't worded it right yet.

I would like to use eocs to spawn a weapon with the player when they start the scenario (You managed to steal a shotgun/medieval weapon when you were hiding), suggestions for the weapon in question?

Edit: I added the rare breeds of dogs to the panic room too, since, well, their owners surely would have taken them there if possible.

ferociousdork and others added 21 commits October 3, 2021 19:20
Co-authored-by: casswedson <58050969+casswedson@users.noreply.github.com>
Co-authored-by: casswedson <58050969+casswedson@users.noreply.github.com>
Add option to toggle display of trait/mutation on player sprite
Change weight and volume of sheet to match deconstructed items
…land

Fix rendering routine on native wayland
* Change existing "wrench" to "adjustable wrench"

Rename existing wrench to have a more specific name, in preparation of
adding several other kinds of wrench.

Also reduce existing wrench volume; steel density is around 8 g/ml.
Preserve original weight, but reduce volume.

Lowering the volume increased the wrench's effective density, making it
do slightly (~0.94) more damage per second, from 7 to 8 DPS. Adjust the
test case accordingly.

* Add new wrenches and wrenching tools

- cordless impact wrench - medium-battery-powered, for bolts or lug nuts
- locking pliers - can turn bolts (but not fine bolts), and clamp
- socket wrench set - regular or fine bolts, but not lug nuts
- socket screwdriver set - screws or fine bolts
- large adjustable wrench - large bolts or lug nuts
- small adjustable wrench - fine bolts only

* Add new wrench tools to various itemgroups

* Remove WHEEL_FAST from gunsmith kits and bionic

* Change vehicle wheel requirement to tools

Listing specific tools that can fasten a vehicle wheel allows the use of
charged power tools like the cordless impact wrench.

Including the WHEEL_FAST quality requirement is redundant in this case
and clutters the UI, but these three tools are now the only ones with
that quality.
…erator_invalidation

Fix effect iterator invalidation
A couple of these messages were unhelpful or invalid (e.g. passing the
wrong number of args for a format string).  Fix that.
BrettDong and others added 26 commits October 19, 2021 12:09
Add SPELL to the list of tilset ids in table.py
* Use ellipsis character consistently

Makes every instance of "…" the same, no spaces before, only one space
after and this character does not end a sentence

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
…special_test

Document trick for testing mutable specials
…ble_joins_bug

Support mismatched available joins
* Fix some grammar

* Add missing terminal punctuation for the default sound string
…nes ) (CleverRaven#51546)

Co-authored-by: Saicchi <Saicchi@users.noreply.github.com>
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
@Termineitor244
Copy link
Contributor Author

Agh... I will close this and open an new PR with the changes

@Termineitor244 Termineitor244 mentioned this pull request Oct 19, 2021
@Termineitor244 Termineitor244 deleted the Mansion-Start branch October 21, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.