M249/M240 semi triggers give select fire #65883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
Shouldn't this be called "select fire trigger" then if it allows both 🤔 |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Machine gun semi auto mods don't override the default burst"
Purpose of change
The PR #53821 that introduced trigger mods for M249 and M240 references the patent https://patents.google.com/patent/US8087343B2/en which states it enables select fire, but in-game if you install the mod it actually only allows semi automatic fire.
Describe the solution
Make it select fire.
ALSO, makes the recipe need the gunsmithing prof when previously it was just welding.
Describe alternatives you've considered
Decide that it's intentional that it's semi auto only as a more improvised conversion done by the survivor rather than referencing a professionally made mechanism from a manual.
Testing
Additional context