Amphib. Adds #4 - Dead Frogs Draft #71475

TheSaddestGoomba · 2024-02-03T21:19:04Z

Summary

Content "Add 7 new frog zombie varities and audit existing frog zombies"

Purpose of change

To add more distinct frog zombies to fit the existing frog mutants and to clean up entries for existing frog zombies.
For example, giant treefrogs and toads will no longer zombify into zombullfrogs but rather more fitting variants.

Describe the solution

Add an abstract entry for frog zombies and have all others use "copy_from" to reduce json size.
Remove flags like FILTHY from frog mom and dad, and remove the FROG species from gastro bufo.
Adds 7 new zombie frogs:

Zombie Toad - a simple reskinning of zombullfrog for mutated toads to zombify into.
Bloated Zoad - a mid-point toad zombie that trails light sludge and leaves a puddle of it on death.
Warted Monstrosity - large version of bloated toad, full sludge trail and huge splash of sludge on death.
Deathmask Zoad - zombification of the great beaked toad mutant that keeps its bony platings and beak.
Zapping Zombfrog - zombie for the electric frog mutants; this one is intended to only have the electric abilities it had in life (like an electric eel), in anticipation of shocker zombies being reworked
Croaked Climber - zombified giant treefrog, weaker but more nimble than zombie toads and zombullfrogs.
Shadow Leaper - shady variant of the zombified treefrogs.

Describe alternatives you've considered

Moving the gastro bufo entry into the same file as the rest, or moving all frog zombies into their own .json file.

Testing

Testing is complete:

All zombifications and upgrades are functioning as intended.
- As noted elsewhere ( Cocoon Samples #63791 ), the sample drop issue rears its head here when 'warted monstrosities' revive from 'gargantuan toads.'
Combat tests completed for each new creature (using the standard loadouts).
- Most are manageable by even early game characters that are prepared (rubber gloves against 'jumping jolter', etc.)
- Numbers and situation (such as fighting 'leaping shadows' at night) make them much more challenging.
- The 'death mask zoad' is appropriately difficult even late game; like a weaker but more mobile 'skeletal juggernaut.'
- Special abilities like sludge trails feel properly tuned.
- Difficulty ratings seem fitting to experience.

Additional context

4th implementation of #67029
Thanks to BlizzDA for help with naming

-Adds zombie frog abstract -Applies copy-from to existing frog zombies and condenses entries appropriately -Adds entries for seven new frogs zombie varities

-Gives the creature a bodytype (snake) -Adds the amphibian proficiency to families -Removes the FILTHY flag

Added correct plural for warted monstrosity

BlizzDA · 2024-02-03T22:50:40Z

The variants seem neat but the names don't exactly scream 'undead' to me. Aside from the one that actually says 'Zombie Toad'. Maybe something like 'Zoad' or 'Zrog' could make it easier to keep track of?

e.g. Zapper Zrog, Deathmask Zoad. (Shady Zrog also makes me think of Crazy Frog)

TheSaddestGoomba · 2024-02-03T23:19:31Z

...the names don't exactly scream 'undead' to me.

Thanks, and yeah, that's a concern I had with some of them. I tried to avoid the 'add a Z to the front' naming convention but it does help with clarity. I like Zoad, I think I'll give that treatment to the 'Bloated Zoad' and 'Death Mask Zoad.'

-Change 'toad' to 'zoad' for some creatures -Space 'hindlegs' into 'hind legs' -Add terms to dictionary

Add zoads, plural to dictionary

Created 'sludge death' and 'sludge death mega' as monster attacks based off of existing boomer death special.

-Gave it the same 'speech' lines as shocker zombies -Changed name to 'jumping jolter' -Added 'jolter' to dictionary

Nebnis · 2024-02-05T13:42:21Z

I'm really against more electric shooting enemies in the game specially when most people already hate shockers to the guts, and specially because those electric frogs show up very often too. I don't think i would like a swarm of electric spitting frogs everywhere

TheSaddestGoomba · 2024-02-05T15:20:02Z

If the other (living) electric frogs are too common then that's a mostly separate issue. Those are also non-aggressive and only have zapback.
This (zombie) one will only appear as a revival of those and not from any other source.

-Give death drops of body parts to bloated zoad and warted monstrosity -Increase warted monstrosity death sludge aoe

-Normalized entries, giving grab_drag and grab_followup where appropriate -Gave gastro bufo ACID_BARF -Updated all ranged_pull to have a conditional for maimed_tongue, and log messages -Fix minor grammer error in frog_dad description

BlizzDA · 2024-02-07T09:04:59Z

Thanks, and yeah, that's a concern I had with some of them. I tried to avoid the 'add a Z to the front' naming convention but it does help with clarity. I like Zoad, I think I'll give that treatment to the 'Bloated Zoad' and 'Death Mask Zoad.'

if 'Zom' doesn't fall under the same umbrella, 'zombullfrog' is in the game and 'zomfrog' or 'zompfrog' (like 'swamp') rolls a bit better of the tongue than 'Zrog'. If you're considering anything for the remaining evos. Shocker, Shady Zom/Zompfrog etc.

-Add zombullfrog to its own upgrade group so that they don't always evolve the first time. -Created upgrade groups for zombie toads and zombtreefrogs

-Replace shockstorm from shocker frog with an electric tongue attack; in anticipation of shocker zombies being reimplemented, these only have what the living version already had -Add translation note to 'Croaked Climber'

Change 'great beaked toad's' venom to be pain-inducing rather than paralytic. Intended to bring it in line with earlier evolutions, painful, stinging toxins.

Fix zombtreefrog upgrades

-Gave the sludge-releasing zoads the very important SLUDGEPROOF flag -Gave each of them a ranged_pull -Gave Gastro Bufo a small acid trail and removed its RANGED_ATTACKER flag

Based on BlizzDA's suggestions, renamed zombified electric frog to "Zapping Zombfrog"

github-actions · 2024-02-14T00:06:56Z

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

zapping zombfrog
zapping zombfrogs

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Leaping Shadow -> Shadow Leaper Dictionary Additions

TheSaddestGoomba · 2024-02-15T18:53:26Z

This is ready for review.
The only test fails are unrelated mapgen errors.

Maleclypse · 2024-02-17T01:04:28Z

Looks neat. Thanks!

Initial Commit for Monsters

03e008b

-Adds zombie frog abstract -Applies copy-from to existing frog zombies and condenses entries appropriately -Adds entries for seven new frogs zombie varities

github-actions bot added the [JSON] Changes (can be) made in JSON label Feb 3, 2024

Audit Tadpole Constrictor

0dfea25

-Gives the creature a bodytype (snake) -Adds the amphibian proficiency to families -Removes the FILTHY flag

github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 3, 2024

TheSaddestGoomba added 2 commits February 3, 2024 17:47

Correct Pluralization

81b341c

Added correct plural for warted monstrosity

Deathmask to death mask

6fee2b4

TheSaddestGoomba added 5 commits February 3, 2024 18:24

Names and Dictionary

a28f087

-Change 'toad' to 'zoad' for some creatures -Space 'hindlegs' into 'hind legs' -Add terms to dictionary

Update dictionary.txt

ae4098f

Add zoads, plural to dictionary

Add Zombify connects and avoid contractions

aab76a4

Sludge Deaths 1st Pass

7627d56

Created 'sludge death' and 'sludge death mega' as monster attacks based off of existing boomer death special.

Update shocker frog

f60f723

-Gave it the same 'speech' lines as shocker zombies -Changed name to 'jumping jolter' -Added 'jolter' to dictionary

github-actions bot added the Monsters Monsters both friendly and unfriendly. label Feb 4, 2024

Correct units for treefrog zombies

ecfb075

TheSaddestGoomba added 2 commits February 5, 2024 23:10

Sludge Toad Death Drops

6deb34a

-Give death drops of body parts to bloated zoad and warted monstrosity -Increase warted monstrosity death sludge aoe

Update Special Attacks

4d5aa61

-Normalized entries, giving grab_drag and grab_followup where appropriate -Gave gastro bufo ACID_BARF -Updated all ranged_pull to have a conditional for maimed_tongue, and log messages -Fix minor grammer error in frog_dad description

Update zombies.json

7ceb524

-Add zombullfrog to its own upgrade group so that they don't always evolve the first time. -Created upgrade groups for zombie toads and zombtreefrogs

github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Feb 11, 2024

TheSaddestGoomba added 3 commits February 10, 2024 23:56

Update zed_misc.json

02fb5e8

-Replace shockstorm from shocker frog with an electric tongue attack; in anticipation of shocker zombies being reimplemented, these only have what the living version already had -Add translation note to 'Croaked Climber'

Update reptile_amphibian.json

1ee6d1e

Change 'great beaked toad's' venom to be pain-inducing rather than paralytic. Intended to bring it in line with earlier evolutions, painful, stinging toxins.

Update zed_misc.json

aabcf73

Fix zombtreefrog upgrades

TheSaddestGoomba mentioned this pull request Feb 11, 2024

Cocoon Samples #63791

Open

TheSaddestGoomba added 2 commits February 12, 2024 18:33

Fix Leaky Toad Problems

1cf9196

-Gave the sludge-releasing zoads the very important SLUDGEPROOF flag -Gave each of them a ranged_pull -Gave Gastro Bufo a small acid trail and removed its RANGED_ATTACKER flag

Re-rename shocker frog

86638c8

Based on BlizzDA's suggestions, renamed zombified electric frog to "Zapping Zombfrog"

Linting

0879c99

github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 14, 2024

Name changes

ff8ff56

Leaping Shadow -> Shadow Leaper Dictionary Additions

TheSaddestGoomba marked this pull request as ready for review February 15, 2024 18:52

github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 15, 2024

Maleclypse merged commit 9284d12 into CleverRaven:master Feb 17, 2024
29 of 32 checks passed

TheSaddestGoomba deleted the Dead-Frogs branch February 18, 2024 21:49

TheSaddestGoomba mentioned this pull request Feb 20, 2024

Boomers Leave Gibs #71862

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amphib. Adds #4 - Dead Frogs Draft #71475

Amphib. Adds #4 - Dead Frogs Draft #71475

TheSaddestGoomba commented Feb 3, 2024 •

edited

Loading

BlizzDA commented Feb 3, 2024 •

edited

Loading

TheSaddestGoomba commented Feb 3, 2024

Nebnis commented Feb 5, 2024

TheSaddestGoomba commented Feb 5, 2024

BlizzDA commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024

TheSaddestGoomba commented Feb 15, 2024

Maleclypse commented Feb 17, 2024

Amphib. Adds #4 - Dead Frogs Draft #71475

Amphib. Adds #4 - Dead Frogs Draft #71475

Conversation

TheSaddestGoomba commented Feb 3, 2024 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

BlizzDA commented Feb 3, 2024 • edited Loading

TheSaddestGoomba commented Feb 3, 2024

Nebnis commented Feb 5, 2024

TheSaddestGoomba commented Feb 5, 2024

BlizzDA commented Feb 7, 2024 • edited Loading

github-actions bot commented Feb 14, 2024

TheSaddestGoomba commented Feb 15, 2024

Maleclypse commented Feb 17, 2024

TheSaddestGoomba commented Feb 3, 2024 •

edited

Loading

BlizzDA commented Feb 3, 2024 •

edited

Loading

BlizzDA commented Feb 7, 2024 •

edited

Loading