Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't extract the remaining abstract things #76702

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "Dont extract abstract monsters and spells from data/json/monsters/"

Purpose of change

Another purge of abstract spells and monsters.

Describe the solution

Mark such names with a flag to skip extraction into translation files if the description is not copied anywhere.
Not changing the part with the frogs yet, because #76680 is working on it.

Describe alternatives you've considered

Testing

The game loads correctly. Marked names are now missing from .pot file.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Mechanics: Enchantments / Spells Enchantments and spells Translation I18n json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 28, 2024
@Maleclypse Maleclypse merged commit de3f2b6 into CleverRaven:master Sep 28, 2024
26 checks passed
@Uwuewsky Uwuewsky deleted the no-i18n-monster branch September 29, 2024 02:14
@TheSaddestGoomba
Copy link
Contributor

@Uwuewsky
#76680 is now merged if you want to work the frogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly. Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants