Eliminate some premature division #2 #76962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Various places in the codebase divide integers before multiplying them, resulting in premature/unnecessary/extra truncation
Describe the solution
Rearranged code to put multiplications before divisions, or converted ints to floats sooner or at all in some calculations.
Describe alternatives you've considered
Testing
Ran test suite. Playing the game with this currently. I have not managed to reproduce most of the necessary scenarios yet, though.
Additional context
This is a sequel to #64808. I am open to suggestions to do more casts to float or double sooner, rather than just rearranging integer operations, especially where the result ends up in a float or double anyway.