Crafting GUI: Filter recipes by what can fit into the result (longest_side, volume, mass)

[Brambor]

Summary

Interface "Crafting GUI: Filter recipes by what can fit into the result (longest_side, volume, mass)"

Purpose of change

• Part of Filter items with pockets by pocket's length, weight, volume #74635 - crafting GUI, not AIM (That is for my next PR.)

Describe the solution

1. add filters L:, V:, M: to crafting GUI
2. Parse user input by an existing parser for units. It is the same parser that is used for loading itypes from JSON.
3. If an error is thrown on invalid input, the user is notified with a helpful message:
   • 
4. Create a fake item, set its longest_side/volume/mass to specified in the filter.
5. For each recipe try fitting the fake item into the recipe item.can_contain(fake_item).
6. fix in item.cpp: units::mass_max * 1.0 resulted in -units::mass_max. Fixed by avoiding multiplying by 1.0.

Describe alternatives you've considered

... I wrote a detailed thing there, where the hell is it?

Testing

• Use all the filters in crafting GUI, try all the suggested "Valid examples". Note: 2m is not valid 2meter is. Maybe not to be confused with minutes?
• Try negative numbers. Like M: -250g.
  • Works for mass and longest_side - all recipes are shown.
  • Doesn't work for volume - none are shown. This is ok.

Additional context

[db48x]

I like the idea. Can you add a comment documenting what the assert is checking for?

Also, why remove wildcards from an unrelated query type?

[Brambor]

Can you add a comment documenting what the assert is checking for?

I went with a different approach and am finalizing it now. The assert will not be there.

Also, why remove wildcards from an unrelated query type?

I added that query type a while back and didn't know better. Now I know and I want to make it in line with the other filters.

It can be a separate PR, I aggregated it since it is close by.

[db48x]

Probably better to have a separate pull request for that then.

[Brambor]

I updated to the new approach. I still need to do the inventory filter, which will have to be a bit different since I cannot throw that helpful error on every keystroke (the inventory filter is live).

[Brambor]

I decided this is good to go. I want to look into AIM a bit more separately. There seems to be room for performance improvement in regards to filtering cache (caching the filter function).

[Brambor]

• This does have a merge conflict with lcmatch instead of wildcard_match for (by)product filter r: #78423. I am happy to rebase one of the PRs once the other gets merged.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• 450 ml

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[Brambor]

Huh, didn't know a special name was requested:

It should have said so in the last error, when it asked me to make it a global variable!

Edit: And the next error. It should have told me where to put the string so that it is sorted!