Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate popups in pocket settings menu to ImGui #78453

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Dec 9, 2024

Summary

Interface "Migrate popups in pocket settings menu to ImGui"

Purpose of change

Describe the solution

Migrate to Imgui.

Describe alternatives you've considered

Testing

Priority before (behind the window):
image

Priority after:
image

  • Check values 12 and -5 work

Save preset before:
image

Save preset after:
image

This shadow is not there either anymore:
image

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 9, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 10, 2024
@PatrikLundell
Copy link
Contributor

I may misinterpret your description, but if this PR only addresses one of two issues (and the other one hasn't been fixed elsewhere already), it shouldn't use a code word that closes the issue, but rather one that isn't a code word (like contributes to, so the PR is still linked to by the bug report).

@Brambor
Copy link
Contributor Author

Brambor commented Dec 10, 2024

  • This PR is the last nail in the issue. Except for one additional misbehaviour, which I made issue PageUp, Home misbehave in pocket settings menu #78469 for right now.
  • My thought process for the keyword was: "This will resolve the last problem, so I will close the issue once this PR is merged. Then I can just automate that with the keyword resolves."

That huge issue agglomerate has to end in favour of small issues. And there is nothing left there except for this PR and the issue I just made.

@Night-Pryanik Night-Pryanik merged commit 3e10020 into CleverRaven:master Dec 11, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pocket 'Set priority' input box was hidden uilist issues from migration #74341
3 participants