From f157ef80e1395a6afd7412e7abc7517e834783d9 Mon Sep 17 00:00:00 2001 From: sriharshakandala Date: Mon, 12 Jun 2023 16:31:12 -0700 Subject: [PATCH] Fix parsing bug for custom resolution option in 3d rising bubble driver. --- .buildkite/pipeline.yml | 8 ++++++++ examples/hybrid/box/bubble_3d_invariant_rhoe.jl | 14 +++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index bb18568800..75d2a31f2f 100755 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -468,6 +468,14 @@ steps: agents: slurm_gpus: 1 + - label: ":flower_playing_cards: Rising Bubble 3D hybrid invariant (ρe), custom resolution" + key: "gpu_rising_bubble_3d_hybrid_invariant_rhoe_custom" + command: + - "nsys profile --trace=nvtx,cuda --output=output/$$BUILDKITE_STEP_KEY/report julia --color=yes --project=examples examples/hybrid/box/bubble_3d_invariant_rhoe.jl Float64 custom 1000 1000 4 16 3 0.05 700.0" + artifact_paths: + - "examples/hybrid/box/output/gpu_bubble_3d_invariant_rhoe_custom/*" + agents: + slurm_gpus: 1 - label: ":computer: Density current 2D hybrid invariant total energy" key: "cpu_density_current_2d_hybrid_invariant_total_energy" diff --git a/examples/hybrid/box/bubble_3d_invariant_rhoe.jl b/examples/hybrid/box/bubble_3d_invariant_rhoe.jl index e53aa1eb00..991f680263 100644 --- a/examples/hybrid/box/bubble_3d_invariant_rhoe.jl +++ b/examples/hybrid/box/bubble_3d_invariant_rhoe.jl @@ -358,13 +358,13 @@ function bubble_3d_invariant_ρe(ARGS, comms_ctx, ::Type{FT}) where {FT} resolution = get(ARGS, 2, "low") if resolution == "custom" args = ( - FT(get(ARGS, 3, 1000)), - FT(get(ARGS, 4, 1000)), - get(ARGS, 5, 4), - get(ARGS, 6, 16), - get(ARGS, 7, 3), - FT(get(ARGS, 8, 0.05)), - FT(get(ARGS, 9, 700.0)), + parse(FT, get(ARGS, 3, "1000")), + parse(FT, get(ARGS, 4, "1000")), + parse(Int, get(ARGS, 5, "4")), + parse(Int, get(ARGS, 6, "16")), + parse(Int, get(ARGS, 7, "3")), + parse(FT, get(ARGS, 8, "0.05")), + parse(FT, get(ARGS, 9, "700.0")), ) else args = ()