Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convergence test for indefinite integrals #1508

Open
charleskawczynski opened this issue Oct 20, 2023 · 0 comments
Open

Add convergence test for indefinite integrals #1508

charleskawczynski opened this issue Oct 20, 2023 · 0 comments
Labels

Comments

@charleskawczynski
Copy link
Member

We should add spatial convergence tests to our indefinite integrals. Cross ref discussion: #1504 (comment). Doing this requires collecting the errors and, at the moment this involves 2 loops already, maintaining a 3-tuple dictionary seems like a bit overkill (we need to collect the errors to compute the convergence rate). Maybe there's a simple way we can do this, but it requires a bit of thought. I've already (offline) confirmed that the operator is 2nd order accurate. Also, the existing tests in ClimaAtmos fail with small MSE error changes, so I think this is closely approximating SciMLBase.solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant