Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1920 broke CI on Julia 1.11 #1923

Closed
charleskawczynski opened this issue Aug 10, 2024 · 0 comments · Fixed by #2018
Closed

#1920 broke CI on Julia 1.11 #1923

charleskawczynski opened this issue Aug 10, 2024 · 0 comments · Fixed by #2018
Assignees
Labels
bug Something isn't working

Comments

@charleskawczynski
Copy link
Member

#1920 broke CI on Julia 1.11.

For some reason, Base.Broadcast in Julia 1.10 does not seem to require getindex(::AbstractData, ::Integer) to be defined, but it does seem to be required on Julia 1.11.

We can revert #1920 all within the DataLayouts module, if we need to. But it may be better to figure out why this behavior changed across Julia versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant