Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O1.2.1 (part of) GPU support for CloudMicrophysics.jl #164

Closed
8 of 9 tasks
Tracked by #1980
trontrytel opened this issue Aug 16, 2023 · 1 comment
Closed
8 of 9 tasks
Tracked by #1980

O1.2.1 (part of) GPU support for CloudMicrophysics.jl #164

trontrytel opened this issue Aug 16, 2023 · 1 comment
Assignees

Comments

@trontrytel
Copy link
Member

trontrytel commented Aug 16, 2023

Objective

Make all CloudMicrophysics.jl functions GPU compatible.

People and Personnel

Components

  • CloudMicrophysics.jl already has tests that run on the GPU. The majority of functions are simple point-wise functions that should not pose any issues.
  • Might benefit from refactoring how we handle the parameter struct.
  • The only thing we really need to decide right now is how to handle asserts and warnings.

Inputs

  • Decide how to handle asserts and warnings for when someone is calling a parameterization outside of it's accepted range of inputs.

Results and Deliverables

  • Do we want to have above 90% GPU test code coverage? Or is that an overkill, given that we have a very high CPU test coverage? Is it enough for the GPU tests to test an example function from each module?

Task Breakdown And Schedule

Going through the modules in the order of how we will need them:

Additional items (would be nice, but not strictly necessary)

SDI Revision Log

CC

@tapios @simonbyrne @cmbengue

@trontrytel trontrytel added the SDI label Aug 16, 2023
@trontrytel trontrytel added this to the GPU support milestone Aug 16, 2023
@trontrytel trontrytel added the GPU label Aug 16, 2023
@trontrytel trontrytel changed the title GPU support GPU support for CloudMicrophysics.jl Aug 21, 2023
@trontrytel trontrytel changed the title GPU support for CloudMicrophysics.jl O1.2.1 (part of) GPU support for CloudMicrophysics.jl Sep 6, 2023
@trontrytel
Copy link
Member Author

Checking this as done.

Tackling the logging will take longer and it's not immediately needed to run on the GPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants