Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flexibility to AerosolDistribution specification #63

Open
claresinger opened this issue Apr 28, 2022 · 0 comments
Open

add flexibility to AerosolDistribution specification #63

claresinger opened this issue Apr 28, 2022 · 0 comments
Labels

Comments

@claresinger
Copy link
Member

Right now AerosolDistribution expects each AerosolMode to have the same number of components. It would be nice to make this more general. E.g. so you can have AM1 with just sulfate and AM2 with a mixture of sulfate and insoluble.

See example of what must be done currently to avoid this "feature" here:

if X in (1,4)
mass_mixing_ratios_1 = (1.0,)
n_components_1 = 1
paper_mode_1_B = AM.Mode_B(
r_dry_1,
stdev_1,
N_1,
mass_mixing_ratios_1,
(ϵ_sulfate,),
(ϕ_sulfate,),
(M_sulfate,),
(ν_sulfate,),
(ρ_sulfate,),
n_components_1,
)
end
if X in (2,3,5)
mass_mixing_ratios_1 = (1.0,0.0)
n_components_1 = 2
paper_mode_1_B = AM.Mode_B(
r_dry_1,
stdev_1,
N_1,
mass_mixing_ratios_1,
(ϵ_sulfate, ϵ_insol),
(ϕ_sulfate, ϕ_insol),
(M_sulfate, M_insol),
(ν_sulfate, ν_insol),
(ρ_sulfate, ρ_insol),
n_components_1,
)
end

@claresinger claresinger added the enhancement New feature or request label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants