Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes at the module level cannot have circular dependencies. #69

Closed
ali-ramadhan opened this issue Feb 22, 2019 · 3 comments
Closed
Labels
cleanup 🧹 Paying off technical debt

Comments

@ali-ramadhan
Copy link
Member

We must play this annoying game of organizing the definitions to avoid mutually circular type declarations.

See: JuliaLang/julia#269

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Feb 22, 2019
@ali-ramadhan
Copy link
Member Author

Closing as we can't do anything about this.

@astrobc1
Copy link

This should absolutely be addressed.

"We can't do anything about this" is an irresponsible and silly claim to make. Who is "we"? With Julia, you can effectively implement nearly anything you want via macros. Want to do implement (possibly nearly) effective (insert language here) like syntax in Julia? Macros.

Ultimately, this is something to be addressed in the fundamental usage of local namespaces in the base julia language.

I love Julia. But this needs addressed. You can't say "Talks like Python" without such a fundamental Pythonic trait. I've yet to find any reasonable workaround for this. It's not to say there isn't one.

@ali-ramadhan
Copy link
Member Author

Hi @astrobc1, this is an ancient issue for the Oceananigans.jl package. We've organized the modules in Oceananigans.jl in a more logical way a long time ago so this issue has not been relevant for over a year.

We (the Oceananigans.jl developers) are not Julia developers and cannot fix JuliaLang/julia#269. If you are interested, it seems that JuliaLang/julia#32658 might resolve the issue as part of Julia 1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

No branches or pull requests

2 participants