Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrayCompact function - remove consecutive identical elements. #7204

Closed
alexey-milovidov opened this issue Oct 6, 2019 · 8 comments
Closed
Labels
easy task Good for first contributors feature st-fixed

Comments

@alexey-milovidov
Copy link
Member

Use case
arrayCompact(['a', 'a', 'b', 'b', 'a']) = ['a', 'b', 'a']

#7147

@alexey-milovidov alexey-milovidov added feature easy task Good for first contributors labels Oct 6, 2019
@dsmith47
Copy link

dsmith47 commented Oct 7, 2019

I would be interested in working on this. Test/structure wise, would it be fair to say that arrayConcat is a good model for adding functions?

@alexey-milovidov
Copy link
Member Author

You can also look at FunctionArrayMapped.h and arrayFilter.cpp.
You can make this function as a higher order function similar to arrayMap and arrayFiler.

@divyansshhh
Copy link

Can I work on this?

@alexey-milovidov
Copy link
Member Author

@divc99 Sure. It will be very appreciated!

@jatin33
Copy link

jatin33 commented Oct 14, 2019

Hi @alexey-milovidov,

Can I work on this?
Please assign it to me if possible.
Thanks in advance.

@alexey-milovidov
Copy link
Member Author

@jatin33 Yes, you can work on this task.

@alexey-milovidov
Copy link
Member Author

I can merge a pull request from @dsmith47, @divc99, @jatin33 - whoever will do it first or do it better.

@alexey-milovidov
Copy link
Member Author

alexey-milovidov commented Oct 14, 2019

Note that GitHub does not allow to assign issues to people outside of the teams.
isaacs/github#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy task Good for first contributors feature st-fixed
Projects
None yet
Development

No branches or pull requests

4 participants