Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Linking clickhouse-cpp-lib target will not set the include directories correctly. #244

Closed
KuribohG opened this issue Nov 2, 2022 · 1 comment
Assignees

Comments

@KuribohG
Copy link
Contributor

KuribohG commented Nov 2, 2022

I used add_subdirectory(third_party/clickhouse-cpp EXCLUDE_FROM_ALL) to import the targets of clickhouse library.

However in the root CMakeLists.txt of this project, the directories required is specified by INCLUDE_DIRECTORIES, not TARGET_INCLUDE_DIRECTORIES. So only linking the target in CMake is not enough, which is not encouraged by modern CMake practice.

Is it feasible to modify the CMake files, so external projects can import clickhouse more conveniently?

@Enmk
Copy link
Collaborator

Enmk commented Nov 10, 2022

Hi @KuribohG ! Thank you for reporting, sure, please submit a PR!

@Enmk Enmk assigned Enmk and KuribohG and unassigned Enmk Nov 11, 2022
@Enmk Enmk closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants