file fd leak

[fengjun2016]

Observed

1.open file fd but not close in time

Expected behaviour

no file fd leak

Code example

file location: internal/cmd/release/main.go

func gitHubOutputReleaseURLIfAvailable(url string) {
	if len(url) == 0 {
		return
	}

	gitHubOutputFile, exists := os.LookupEnv("GITHUB_OUTPUT")
	if !exists {
		return
	}

	f, err := os.OpenFile(gitHubOutputFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
	if err != nil {
		log.Fatalln(err)
		return
	}
        
        // return but not close f fd, then fd leak
	if _, err := f.WriteString(fmt.Sprintf("RELEASE_URL=%s\n", url)); err != nil {
		log.Fatalln(err)
		return
	}

	if err := f.Close(); err != nil {
		log.Fatalln(err)
		return
	}
}

Tasks

Preview Give feedback

No tasks being tracked yet.