Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite parameter substitution #625

Closed
gingerwizard opened this issue Jun 21, 2022 · 1 comment · Fixed by #854
Closed

Rewrite parameter substitution #625

gingerwizard opened this issue Jun 21, 2022 · 1 comment · Fixed by #854
Assignees
@jkaflik
Labels
enhancement
Milestone
2.5.0

Comments

@gingerwizard
Copy link
Collaborator

Current parameter substitution in bind.go isn't robust and a source of pain. Ideally, we would move to ClickHouse and pass the parameters with the query.

Depends on ClickHouse/ClickHouse#38235
@gingerwizard gingerwizard self-assigned this Jun 21, 2022
This was referenced Jul 6, 2022
Closed
Merged
@mshustov
Copy link
Member

ClickHouse/ClickHouse#38235 is closed

@gingerwizard gingerwizard added this to the v3.0.0 milestone Sep 13, 2022
@gingerwizard gingerwizard modified the milestones: v3.0.0, 2.5.0 Dec 2, 2022
@jkaflik jkaflik assigned jkaflik and unassigned gingerwizard Dec 16, 2022
@jkaflik jkaflik mentioned this issue Dec 16, 2022
Merged
@makeavish makeavish mentioned this issue Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaflik jkaflik

Labels
enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Query parameters support ClickHouse/clickhouse-go
3 participants
@jkaflik @mshustov @gingerwizard