Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to support dbt-core v1.2.0 #79

Closed
5 tasks
dataders opened this issue Jul 14, 2022 · 6 comments
Closed
5 tasks

upgrade to support dbt-core v1.2.0 #79

dataders opened this issue Jul 14, 2022 · 6 comments
Assignees

Comments

@dataders
Copy link

We've just published the release cut of dbt-core 1.2.0, dbt-core 1.2.0rc1 (PyPI | GitHub release notes).

dbt-labs/dbt-core#5468 is an open discussion with more detailed information, and dbt-labs/dbt-core#5474 is for keeping track of the communities progress on releasing 1.2.0

Below is a checklist of work that would enable a successful 1.2.0 release of your adapter.

  • migrate necessary cross-db macros into adapter and ensure they're tested accordingly
  • remove any copy-and-pasted materialization (if your adapter inherits from another adapter)
  • add new basic tests BaseDocsGenerate and BaseDocsGenReferences
  • consider checking and testing support for Python 3.10

dbt-labs/dbt-core#5432 might make it into the second release cut in the next week, in which case, you'll also might want to:

  • implement method and tests for connection retry logic
@jesperbagge
Copy link

Would love for this to happen since table materializations fails using dbt-core==1.2.0 and dbt-clickhouse==1.1.7

@genzgd
Copy link
Contributor

genzgd commented Aug 25, 2022

We should get to this over the next week or two.

@genzgd genzgd self-assigned this Aug 31, 2022
@genzgd
Copy link
Contributor

genzgd commented Sep 1, 2022

@jesperbagge Do you have an example of how table materializations fail when using dbt 1.2? The basic materializations are working for me and in our automated tests, so I'd like to understand the problem.

@jesperbagge
Copy link

Well honestly, that makes us two. I created a fresh virtualenv using python3.9 and just ran pip install dbt-clickhouse which gave me

dbt-clickhouse==1.1.7
dbt-core==1.2.1

And now I can't seem to be able to recreate the problem. It works like it should. I even recreated my venv with specifically targeting dbt-core==1.2.0 but this also works as expected. I don't know what I messed up in my initial project but I'm sorry for taking up your time.

@genzgd
Copy link
Contributor

genzgd commented Sep 19, 2022

Closed with the latest 1.2.1 release

@genzgd genzgd closed this as completed Sep 19, 2022
@mshustov
Copy link
Member

done in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants