[WIP] Directory #186
Closed
[WIP] Directory #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to add I've based the initial work off the golang and python implementation. I've also used the notes from the erlang implementation that we using for CouchDB. |
Speedy37
reviewed
Mar 13, 2020
| @@ -6,7 +6,7 @@ fdb_rs_dir=$(pwd) | |||
|
|
|||
| case $(uname) in | |||
| Darwin) | |||
| brew install mono | |||
| # brew install mono | |||
There was a problem hiding this comment.
Suggested change
| # brew install mono | |
| command -v mono || brew install mono |
Speedy37
reviewed
Mar 13, 2020
| @@ -22,7 +22,7 @@ esac | |||
| cd ${fdb_builddir:?} | |||
|
|
|||
| ## Get foundationdb source | |||
| git clone --depth 1 https://github.com/apple/foundationdb.git -b release-6.1 | |||
| # git clone --depth 1 https://github.com/apple/foundationdb.git -b release-6.1 | |||
There was a problem hiding this comment.
Suggested change
| # git clone --depth 1 https://github.com/apple/foundationdb.git -b release-6.1 | |
| [[ -d foundationdb ]] || git clone --depth 1 https://github.com/apple/foundationdb.git -b release-6.1 |
Speedy37
reviewed
Mar 13, 2020
| let key = self.subspace.subspace(&b"layer".to_vec()); | ||
| self._layer = match trx.get(key.bytes(), false).await { | ||
| Ok(None) => Some(Vec::new()), | ||
| Err(_) => Some(Vec::new()), |
There was a problem hiding this comment.
I don't think silencing an FdbError is ok.
layer should probably return a Result
| subspace: Subspace, | ||
| path: Vec<String>, | ||
| target_path: Vec<String>, | ||
| _layer: Option<Vec<u8>> |
There was a problem hiding this comment.
Layer being used as a cache you might want to consider https://docs.rs/futures/0.3.4/futures/future/trait.FutureExt.html#method.shared.
RefCell might also be required in order to not requires &mut self on a lot of methods (but be careful about dynamic borrows lifespans in async context).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to get the directory layer working with the rust client. Its currently still very rough
and doesn't even compile yet.
If any of the maintainers want to contribute feel free to push code. I'm also on the rust discord (redcomet) if you want to chat about it.