Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/adjust icons on the country profile pages to include NDC 3.0 #1717

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

SARodrigues
Copy link
Collaborator

Basecamp: 2.1- Add/Adjust icons under “What climate commitments has [country] submitted?” - Country Profile

Copy link

what-the-diff bot commented Nov 26, 2024

PR Summary

  • Updated Component Styling for Label
    The appearance of the label in the country climate commitment section has been enhanced by incorporating a new CSS class known as .labelDescription. This change provides better text formatting through set minimum height and alignment.

  • Addition of New Indicator to Component
    A new indicator code INDICATOR_SLUGS.submitted2025 has been integrated into the NDCSProvider component. This serves as a pointer that will facilitate the tracking of specific changes related to 2025 Nationally Determined Contributions (climate change mitigation plans).

  • Modifications in Selector Function
    The selector function has been refined to recognize and manage the newly added status2025indicator. If this indicator is not present, it will return a nonexistent result (null).

  • Improved Data Retrieval and Representation
    The logic to fetch and display the value of the newly added 2025 NDC indicator has been engineered. This provides information about new climate change mitigation plans for the year 2025.

  • Enhanced Display Labels
    The selector's response labels have been updated to deliver more precise and up-to-date information. It now includes '2025 NDC (NDC 3.0)', and 'New or Updated NDC' is now represented as '2020 NDC'.

  • Layout Improvements Through CSS Adjustments
    The overall layout has been improved by making changes to the CSS styles. This includes adjusting column distribution in various screen sizes (media queries) and centering document items for better visual appeal and user experience.

  • Improved Item Alignment
    By amending margin and flex properties, item alignment within the document section is more balanced, leading to cleaner, more organized visuals.

@SARodrigues SARodrigues marked this pull request as ready for review November 26, 2024 13:30
@SARodrigues SARodrigues merged commit e112e76 into develop Nov 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant