-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For MAF: upload SNVs of normal samples to Genotype #882
Comments
@moahaegglund @ashwini06 Would it be possible to use the normal sample SNVs from Balsamic and upload them to Genotype instead of analyzing the same sample again using MIP? |
I let you answer this question @ashwini06, but this would be the best solution for us. |
@ashwini06 would it be possible to upload the SNVs of the normal samples to Genotype? |
@moahaegglund @henrikstranneheim: Somehow I missed this issue to answer, sorry about that! Yes, it might be possible. Currently, BALSAMIC reports SNV germline variants from normal sample. We have those results generated from two separate variants callers (Sentieons DNAscope and GATK haplotypecaller). Maybe we can use one of those for genotype? |
I tested uploading @ashwini06 However genotype gets the sample name from the VCF header and in BALSAMIC the field is called |
@Vince-janv : Yes, it is possible but currently we don't have the functionality to make this change. But with a simple command-line, one can easily change the sample names in the output VCF files.
So it is only you are interested in the sample name change in this output VCF : SNV.germline.normal.dnascope.vcf.gz? |
@ashwini06 Thanks for the quick reply! 😊 I think there is an argument for consistency (ie. using the same header format in all VCFs). But that being said I know very little about how BALSAMIC uses the VCF headers. But for genotype we just need a VCF for the normal, and i chose one of the ones you suggested. The "manual" change you suggested will be great for testing but for use in production we would need another solution. |
@Vince-janv: Agree, that this change needs to be done from BALSAMIC for germline DNAscope files, which you can use in genotype directly. I will get back to you on this once we have a solution implemented in BALSAMIC. |
@ivadym we would also need to add the tag |
Hi. I will summarise some discussions we've had the past weeks. @ashwini06 Informed me that changing the vcf headers is more problematic than initially thought. Discussing with @Mropat and @ivadym we concluded that implementing changes in genotype would be beneficial, but would take a lot of work. With the current lack of developers I think it might not happen for a while if not prioritised. As a quick and dirty fix I suggest that @ivadym adds the tag in housekeeper and I'll merge a small PR in cg to adapt the current genotype upload to balsamic. Production can then re-header the file manually and upload via the cg CLI. Let me stress that this should not be a permanent solution! |
@Vince-janv : Thanks for the update! I have two possible solutions that might work, but again I am on it and testing before I promise something to you. b) To have the same standardized format for sample names (i.e LIMSID instead of TUMOR/NORMAL) in all output VCF and BAM files, it requires huge refactoring with most of the BALSAMIC snakemake rules (for eg) and handling of some wildcards. This could be a permanent solution. This also need some changes on SCOUT balsamic config file creation i guess.. for example: the following
@Vince-janv @ivadym I am on my way in testing my solutions. if its OK, can i ask both to wait a bit before you start fixing your proposed solutions in cg and HK. |
@ashwini06 The default values for |
Fixed in #958 |
Description
When a tumor/normal analysis is ordered with BALSAMIC analysis only we need to create a case for the MIP analysis of the normal sample under cust000 to compare with the results of MAF. For example the samples in ticket 110945. Today prod bioinfo have to create these cases manually.
The text was updated successfully, but these errors were encountered: