Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the analyses to be delivered according to BALSAMIC tags #1389

Closed
4 tasks done
ivadym opened this issue Jan 31, 2022 · 3 comments
Closed
4 tasks done

Define the analyses to be delivered according to BALSAMIC tags #1389

ivadym opened this issue Jan 31, 2022 · 3 comments
Assignees
Labels
Balsamic Issued related to the Balsamic workflow Needs Refinement

Comments

@ivadym
Copy link
Contributor

ivadym commented Jan 31, 2022

Description

Currently, BALSAMIC delivery can be done using three different flags: balsamic, balsamic-analysis and balsamic-qc. However, the files to be delivered are not clearly defined.

Therefore, and taking into account the analysis output files generated (Clinical-Genomics/hermes#44), it would be convenient to discuss and create new tags (if necessary) based on the well-defined customer's requirements.

This can be closed when:

  • A catalog of output analysis files offered to clients has been defined. See following issue.
  • The expected output has been associated to the different flags in CG. Only one tag will be used, see comment below.
  • The used tags and their associated files have been defined. Only one tag will be used, see comment below.
  • The analysis files are successfully uploaded and delivered. @ivadym @keyvanelhami we can check this when deployed
@ivadym ivadym added the Balsamic Issued related to the Balsamic workflow label Jan 31, 2022
@keyvanelhami
Copy link

keyvanelhami commented Mar 23, 2022

This issue is related to this issue where the files today are delivered, and what files that we would like to start/stop deliver are summarized.

My suggestions:
Remove balsamic-qc and balsamic-analysis and only use balsamic flag to deliver everything as suggested in here. The reason why we had the different flags, was because we were delivering big files like bam and concat fastq-files. These files are no longer being delivered and the -d balsamic will be sufficient for delivering all files.

We are also going to add a new flag balsamic-umi which will deliver the files related to the balsamic-umi workflow.

@ashwini06
Copy link
Contributor

ashwini06 commented May 2, 2022

Decision:
@ivadym : will be implementing the changes in cg for cg deliver -d balsamic, while validation for v9.0 is ongoing

@ivadym
Copy link
Contributor Author

ivadym commented May 19, 2022

Closed via #1477.

@ivadym ivadym closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balsamic Issued related to the Balsamic workflow Needs Refinement
Projects
None yet
Development

No branches or pull requests

6 participants