Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compounds only scores first family in VCF #148

Open
fellen31 opened this issue Nov 11, 2024 · 2 comments
Open

Compounds only scores first family in VCF #148

fellen31 opened this issue Nov 11, 2024 · 2 comments

Comments

@fellen31
Copy link
Contributor

Genmod compounds only scores the first family in the VCF. This is not clear from the documentation and only from TODO statements in the code.

This would be nice to fix, or at least document, since other parts of genmod works with multiple families.

#TODO check if correct family id
# Right now we assume that there is only one family in the vcf
family_id = family_rank_score[0]
rank_score = float(family_rank_score[-1])
rank_scores[rank_score_type][variant_id] = rank_score

#TODO Only checks first family now
family_compound_entry = raw_compounds.split(',')[0]
splitted_entry = family_compound_entry.split(':')
compound_family_id = splitted_entry[0]
compound_list = splitted_entry[-1].split('|')
logger.debug("Checking compounds for family {0}".format(
compound_family_id))

@dnil
Copy link
Collaborator

dnil commented Nov 28, 2024

It popped up in linting as well! 😅 Maybe not bug-bug, especially since we always run it one family at the time, but definitely worth fixing.

@fellen31
Copy link
Contributor Author

No maybe not bug, so I removed the label. But in Nallo we ran it with multiple families at the time before I discovered this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants