-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding description to a component spec removes the label from the editor UI #138
Comments
👋 Hi Ed! Thanks for the report. It turns out this is actually a visual bug on the CMS side — this UI is truncating the component label when the description is too long, rather than vice versa. You can see what I mean here: I'll chase this up as a bug internally and report back here when fixed. Another fix that is less of a hacky workaround, and often just a good idea in general, is to use the modal component picker. If you add the following to your _structures:
content_blocks:
style: modal Then you'll pick components from a modal rather than a dropdown, which doesn't exhibit the same bug. Might be good at least as a temporary measure until we get this fixed up 🙂 |
I found that modal setting on the Hydra theme template so that actually works better for my purposes, but my issue still remains that the description wasn’t even truncated, it was absent. Perhaps it didn't like the dash ¯_(ツ)_/¯ It's a separate issue (please don't go stackoverflow on me. i can open a separate issue if necessary), but I'm not getting a preview despite having the settings configured:
I did everything according to the docs, but it's showing blanks. |
Sorry for not getting back to you — did you make any progress on this? I haven't seen the Do you have a screenshot of what you are (or aren't) seeing? |
Ah, yes that's (currently) an unfortunate clash of what Bookshop calls Where you're seeing |
ah got it. so what am i supposed to see when I fill out the component preview data? According to your docs it says "...you might want to see a preview of your component filled out with example data.The preview object will be merged with your blueprint before a component is rendered in the component browser". What steps should I take to see that preview? |
When the Bookshop docs refer to the component browser, they're referring to Bookshop's component browser, i.e. on the starter template: https://balmy-goose.cloudvent.net/components#hero:hugo — this is the component browser that you integrate with or alongside your site, which helps develop and test components locally while building your site. The |
Version Info
Jekyll 4.2.1
"@bookshop/browser": "3.3.0"
"@bookshop/jekyll-engine": "3.3.0"
"@bookshop/live": "3.3.0"
"@bookshop/generate": "3.3.0"
What I'm Doing
I'm adding a label and description to my component specs so that users can see the title of the component they will add and a description of what it is.
What I Expect
When I select Add component on the editor, I expect to at least see the title of the component I want to select.
What's Happening
I see only the truncated description:
I notice if I remove the description, the title will show, but that's just a hacky workaround.
The text was updated successfully, but these errors were encountered: