Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bounce all modules to latest version in usages and fixed policy reference for protected VMs #29

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dkooll
Copy link
Contributor

@dkooll dkooll commented Nov 20, 2024

Description

This PR increments all modules in usages to the latest. All deployment tests will succeed now..
Also the below error is fixed

Error: Unsupported attribute
  on .terraform/modules/rsv/main.tf line 131, in resource "azurerm_backup_protected_vm" "vm":
 131:   backup_policy_id    = azurerm_backup_policy_vm.policy[each.value.policy_name].id
    ├────────────────
    │ each.value is object with 4 attributes
This object does not have an attribute named "policy_name".

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

@dkooll dkooll added the bug Something isn't working label Nov 20, 2024
@dkooll dkooll self-assigned this Nov 20, 2024
@dkooll dkooll requested a review from a team as a code owner November 20, 2024 11:45
@dkooll dkooll merged commit 5cea5d3 into main Nov 20, 2024
4 checks passed
@dkooll dkooll deleted the fix/missing-policy-name branch November 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants