Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type definitions all usages #34

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

dkooll
Copy link
Contributor

@dkooll dkooll commented Dec 6, 2024

Description

This PR adds type definitions to all usages

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

@dkooll dkooll added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 6, 2024
@dkooll dkooll self-assigned this Dec 6, 2024
@dkooll dkooll requested a review from a team as a code owner December 6, 2024 09:47
@dkooll dkooll merged commit 007158c into main Dec 6, 2024
4 checks passed
@dkooll dkooll deleted the feat/add-type-definitions branch December 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants