Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview/imagepartial fix #76

Merged
merged 14 commits into from
Feb 23, 2022
Merged

Preview/imagepartial fix #76

merged 14 commits into from
Feb 23, 2022

Conversation

chrisreddington
Copy link
Contributor

@chrisreddington chrisreddington commented Feb 21, 2022

Description

Several changes, including -

  • Temp fix for package-lock.json
  • Several fixes relating to SEO

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Maintenance / Chore (Something which is needed to enable the project broadly)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • This change is:
    • Updating Site/Page Metadata/Frontmatter and the JSON-LD site_metadata partial has been reviewed for correctness

Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for hugo-creator ready!

🔨 Explore the source changes: 7adee68

🔍 Inspect the deploy log: https://app.netlify.com/sites/hugo-creator/deploys/6214ee09fdb3a3000744a589

😎 Browse the preview: https://deploy-preview-76--hugo-creator.netlify.app

Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

Accessibility Insights Accessibility Insights Action

  • URLs: 17 URL(s) failed, 0 URL(s) passed, and 0 were not scannable
  • Rules: 14 check(s) failed, 19 check(s) passed, and 28 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

Failed instances

  • 6 × link-name: Ensures links have discernible text
  • 2 × aria-required-children: Ensures elements with an ARIA role that require child roles contain them
  • 4 × button-name: Ensures buttons have discernible text
  • 1 × label: Ensures every form element has a label
  • 1 × html-has-lang: Ensures every HTML document has a lang attribute

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
Signed-off-by: Chris Reddington <791642+chrisreddington@users.noreply.github.com>
@chrisreddington chrisreddington merged commit 3140426 into main Feb 23, 2022
@chrisreddington chrisreddington deleted the preview/imagepartial-fix branch February 23, 2022 04:45
@chrisreddington chrisreddington added Priority/High This is of high priority. It should be prioritised over medium and low items. Type/Enhancement New feature or request labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority/High This is of high priority. It should be prioritised over medium and low items. Type/Enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement framework for custom themes
1 participant