Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Run Pretzel under .Net Core? #320

Open
AnonJr opened this issue May 1, 2017 · 21 comments
Open

Run Pretzel under .Net Core? #320

AnonJr opened this issue May 1, 2017 · 21 comments

Comments

@AnonJr
Copy link

AnonJr commented May 1, 2017

This is more an alternative to #81 - instead of trying to support running on Mono, maybe go for .NET Core instead? You'll get the same ultimate goal (cross-platform) and you can keep it to a single code base (instead of having a .NET version and a Mono version).

Just a thought for an old, loved project that seems to have had some recent work. :)

@laedit
Copy link
Member

laedit commented May 1, 2017

I would love that, but it will need a lot of changes.
That does not mean that will never happened, but not before a long time 😞

@AnonJr
Copy link
Author

AnonJr commented May 2, 2017

I understand how that goes. I'll keep following along. :)

@biohazard999
Copy link
Contributor

Do you mind if i fork it and push it over to core and release as a global tool?

@laedit
Copy link
Member

laedit commented Sep 5, 2019

I would love to see that! 😄
It has been in my work list for so long but never had the time to do it.

@biohazard999
Copy link
Contributor

@laedit My plans are: bringing to dotnet core as a global tool and switch to azure devops.

@laedit
Copy link
Member

laedit commented Sep 5, 2019

You mean replace Appveyor by Azure devops?
Do you know if it is possible to have an account for a Github organization?
I'd prefer to avoid user-specific account to prevent any future issue to access it.
I am trying to activate Github Actions but since I am not an admin I don't have access to the settings of this repo.

@shiftkey
Copy link
Member

shiftkey commented Sep 5, 2019

I am trying to activate Github Actions but since I am not an admin I don't have access to the settings of this repo.

@laedit apologies for that, I should have done it a long time ago. I've given you admin rights to this repository now, let me know if there's anything else you need.

@biohazard999
Copy link
Contributor

@laedit Did not use Github actions so far, but for open source it would be a nice fit!
Any suggestions on Microsoft Composition? Move to dependency incjection from dotnet core hosting model or to Microsoft.Composition (which seams dead). I'm currently trying to port to netstandard, but this seams hard so far. (got it compiling and tests running, but composing the catalog fails cause the lack of InheritedExportAttribute that is heavy used)

@biohazard999
Copy link
Contributor

Let's get 🥨 some ❤!

@laedit
Copy link
Member

laedit commented Sep 5, 2019

@shiftkey wow, I was planning to contact you but I have forgotten that you are omniscient 😄
Thanks a lot!

@laedit
Copy link
Member

laedit commented Sep 5, 2019

@biohazard999 I must confess that I haven't peek at the code for a long time, but I think that InheritedExport is used mainly for extensibility, so if that is the only major change we can remove it and contact every known plugin creators to inform them of the change.

And if it is impossible to migrate to MEF2 we could move to another dependency injection lib.

@biohazard999
Copy link
Contributor

@laedit i think the codebase is good and it would be a shame to abandon the project. I look into migrating to MEF2 to move to project forward, but the long term goal to go to Microsoft's new DI would be a nice addition!

My main focus is to move it to an global tool first, and do afterwards some features as required.

@laedit
Copy link
Member

laedit commented Sep 5, 2019

Good to me :)

@biohazard999
Copy link
Contributor

biohazard999 commented Sep 6, 2019

@laedit can you look into the PR #328? I've tested and checked every command, and works (at least with my blog). Although the build is failing it seams like a problem with GitVersion in the install script on the build server. I don't know if I can fix this somehow?

@laedit
Copy link
Member

laedit commented Sep 13, 2019

@shiftkey sorry to bother you, I have access to GitHub Actions but it seems that I must be owner of the organization to activate it on pretzel.
Can you signup for GitHub Actions for Code52?
Thanks!

@biohazard999
Copy link
Contributor

Cause the lack of support of many dependencies (AjaxMin, DotlessClient/Server, Aspnet.Razor) are we going .netcore only? Or do we prefer to keep .net451 as a minimum target and do #if NETSTANDARD?

@laedit
Copy link
Member

laedit commented Sep 16, 2019

I'd like to keep a full .net target for Chocolatey (net451 or later if it simplifies things), but the functionalities should ideally be the same with the netcore target.

So I think we should replace there dependencies by other that supports netcore, like WebMarkupMin.Core for minification, dotless.core for dotless and RazorLight or directly Microsoft.AspNetCore.Razor.Runtime for razore rendering, but it could be done in separates PR and do #if for now.

@biohazard999
Copy link
Contributor

biohazard999 commented Sep 16, 2019

@laedit if we go at least net462 we can use a lot of the new stuff and still be full framework as well as cross plattform (aspnet core is >= 2.2) without writing tons of #if. The only thing is ScriptCS support. But I don't know how much usage there is 😉

@laedit
Copy link
Member

laedit commented Sep 16, 2019

Go for 462 😄

ScriptCs is used only to allow plugins from a .csx file.
Since it does not support netstandard I think we could replace it by dotnet script or another solution.

@biohazard999
Copy link
Contributor

5th of Dec we are on the cross cutting concernes ✔️

@laedit
Copy link
Member

laedit commented Oct 8, 2019

I can't wait to read your article!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants