Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Virtual Directory Support and Protocol-relative URLs #367

Open
foundinhim opened this issue Feb 4, 2020 · 7 comments
Open

Virtual Directory Support and Protocol-relative URLs #367

foundinhim opened this issue Feb 4, 2020 · 7 comments

Comments

@foundinhim
Copy link

Virtual directory support incorrectly prepends the virtual directory to protocol relative URLs

To Reproduce

  1. I created my site with: pretzel create --t=razor --withproject
  2. Then I baked it: pretzel bake --cleantarget --t=razor --destination=docs --vDir=somesite.github.io

This produces <link rel="stylesheet" href="/somesite.github.io//cdn.jsdelivr.net/highlight.js/8.4/styles/default.min.css" />

Expected behavior
I would expect the virtual directory option to ignore protocol-relative URLs.

Desktop (please complete the following information):

  • OS: Win 10
  • Version 1903 (OS Build 18362.592)
@laedit
Copy link
Member

laedit commented Feb 4, 2020

Thanks for the issue! :)
I will try to fix it as soon as I have some spare time but I can't make any promises.
A PR would be rewarded with my infinite thanks!

@foundinhim
Copy link
Author

@laedit, you're welcome, and thank you for looking at this. Perhaps one day I'll have a chance to contribute. This concept is entirely new to me. I heard about Pretzel from Plural Sight.

@biohazard999
Copy link
Contributor

@laedit the last PR's for the global tool are in the making (around weekend), probably I'll look into that

@laedit
Copy link
Member

laedit commented Feb 4, 2020

@biohazard999 Thanks! :D

@laedit
Copy link
Member

laedit commented Feb 4, 2020

@foundinhim No problem.
I didn't even knew that Pretzel was on Plural Sight :)

@foundinhim
Copy link
Author

foundinhim commented Feb 6, 2020

@foundinhim No problem.
I didn't even knew that Pretzel was on Plural Sight :)

@laedit, It is mentioned as one of the alternatives to Jekyll in Serverless Web Applications

@laedit
Copy link
Member

laedit commented Feb 6, 2020

Thanks for the link!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants