Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Clean up Api server env vars #360

Open
rhinodavid opened this issue May 9, 2020 · 0 comments
Open

[web] Clean up Api server env vars #360

rhinodavid opened this issue May 9, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rhinodavid
Copy link
Member

I noticed at least one instance where a component (useTemperature.tsx) is referencing the Server URI:

Screen Shot 2020-05-09 at 4 00 17 PM

We should scrub the package and figure out a way to not have individual components reference this URI, especially with a hardcoded default. It's subject to breakage with changes. One solution would be to have a module that pulls in env vars and sets defaults if necessary, then components import values from that module. Finishing #271 would be very helpful.

Also, note that once #357 lands the client will be on the same server as the API in production so the default should reflect that.

@rhinodavid rhinodavid added the good first issue Good for newcomers label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant