Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property Details: Atlas link should also say "opens in a new tab" #659

Closed
1 task
marvieqa opened this issue May 27, 2024 · 2 comments · Fixed by #692
Closed
1 task

Property Details: Atlas link should also say "opens in a new tab" #659

marvieqa opened this issue May 27, 2024 · 2 comments · Fixed by #692
Assignees
@KenMain5
Labels
A11y Accessibility

Comments

@marvieqa
Copy link
Collaborator

Description

For consistency, we should use aria-label on the Atlas link to say "opens in a new tab" just like the links found in "Transform a Property Page"

Acceptance Criteria

  • add <aria-label="Atlas, opens in a new tab"> on the Atlast link.
@marvieqa marvieqa added the A11y Accessibility label May 27, 2024
@KenMain5
Copy link
Contributor

Can you assign this to me please?

@bacitracin
Copy link
Collaborator

@KenMain5 assigned

@bacitracin bacitracin moved this to In Development in Clean & Green Philly Jun 11, 2024
@CodeWritingCow CodeWritingCow mentioned this issue Jun 12, 2024
Merged
@CodeWritingCow CodeWritingCow moved this from In Development to In Review in Clean & Green Philly Jun 19, 2024
@CodeWritingCow CodeWritingCow moved this from In Review to On Staging in Clean & Green Philly Jun 19, 2024
@github-project-automation github-project-automation bot moved this from On Staging to Live in Clean & Green Philly Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KenMain5 KenMain5

Labels
A11y Accessibility
Projects
Clean & Green Philly
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 659: Add aria label to ThemeButtonLink
3 participants
@bacitracin @marvieqa @KenMain5