Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Merged PRs fail to deploy to Vercel #822

Closed
CodeWritingCow opened this issue Jul 21, 2024 · 2 comments
Closed

Bug: Merged PRs fail to deploy to Vercel #822

CodeWritingCow opened this issue Jul 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Jul 21, 2024

Describe the bug
PRs are failing to deploy to Vercel's preview and production environments. The last successful deployment to production was PR #807 on July 19, 2024, at 11:11 a.m.

To Reproduce
Steps to reproduce the behavior:

  1. Submit and merge a PR from a test branch to staging branch
  2. Submit and merge a PR from staging to main branch
  3. Verify that merged code fails to deploy to production

Expected behavior
Vercel should successfully deploy PRs to production.

Screenshots
@brandonfcohen1 shared a log showing a Vercel build failure due to TypeScript errors. See comments section.

Additional context
This problem began on July 19, 2024, after new GitHub Actions were added to our repo's Workflow. Some possible causes suggested by Nissim and Brandon:

  • A new Release Drafter Workflow for drafting release notes (this workflow is now temporarily disabled)
  • A PR Checks Workflow for linting and formatting frontend PRs; it was updated this week and might be causing Vercel builds to fail if ESLint finds any TypeScript errors
@CodeWritingCow CodeWritingCow added the bug Something isn't working label Jul 21, 2024
@CodeWritingCow CodeWritingCow self-assigned this Jul 21, 2024
@CodeWritingCow CodeWritingCow moved this from To Do to In Development in Clean & Green Philly Jul 21, 2024
@CodeWritingCow
Copy link
Collaborator Author

Below is a snippet of the error log shared by Brandon:

Creating an optimized production build ...
 Compiled successfully
Linting and checking validity of types ...
Failed to compile.

./src/app/find-properties/[[...opa_id]]/page.tsx
11:10  Error: 'FilterProvider' is defined but never used.  @typescript-eslint/no-unused-vars

/src/components/ContentCard.tsx
1:14  Error: 'ReactNode' is defined but never used.  @typescript-eslint/no-unused-vars
37:3  Error: 'description' is defined but never used.  @typescript-eslint/no-unused-vars
38:3  Error: 'linkurl' is defined but never used.  @typescript-eslint/no-unused-vars

@CodeWritingCow
Copy link
Collaborator Author

It turns out there were two causes:

  • Strict TypeScript-ESLint rules introduced by new plugins added to .eslintrc.json
  • The mapbox-gl NPM library being upgraded from v3.2.0 to v3.5.2, which introduced breaking changes

Both problems have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants