Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework DOM to better separate elements from events #1074

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Rework DOM to better separate elements from events #1074

merged 9 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Rework DOM to better separate elements from events 

    Fixes #332

This way, we:
* Fully handle accessing and setting DOM element properties in one
  chunk, then introduce events, rather than muddling the two together.
* Identify that there are two common actions to do, and talk through
  identifying and addressing this.
* Pull out the "what is the character limit" to be defined by the HTML
  attribute, rather than duplicated in the script.
* Practice breaking down the "remaining characters" problem into
  sub-problems.
* Generally solve things more incrementally.
* Explicitly call out "do a clean-up refactoring" at the end.

Also some misc copy edits.
    @illicitonion
    illicitonion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7507219 View commit details
    Browse the repository at this point in the history

  2. Update common-content/en/module/js2/events/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e71db23 View commit details
    Browse the repository at this point in the history

  3. Update common-content/en/module/js2/events/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c209978 View commit details
    Browse the repository at this point in the history

  4. Update common-content/en/module/js2/events/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e237973 View commit details
    Browse the repository at this point in the history

  5. Update common-content/en/module/js2/querying/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3da891b View commit details
    Browse the repository at this point in the history

  6. Update common-content/en/module/js2/querying/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    45e945a View commit details
    Browse the repository at this point in the history

  7. Update common-content/en/module/js2/querying/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7427aa9 View commit details
    Browse the repository at this point in the history

  8. Update common-content/en/module/js2/plan/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6174227 View commit details
    Browse the repository at this point in the history

  9. Update common-content/en/module/js2/plan/index.md 

    Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
    @illicitonion @SallyMcGrath
    illicitonion and SallyMcGrath committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bb57bdc View commit details
    Browse the repository at this point in the history