Add isFinite.md to JavaScript #344

Keshraf · 2021-10-07T21:29:02Z

Description

Language: JavaScript
File: concepts/number-methods/terms
Added Folder: isFinite
Added File: isFinite.md
Close #345

Pull Request for the Hacktober Fest 2021

Type of Change

Adding a new entry

Checklist

All writings are my own.
My entry follows the Codecademy Docs style guide.
My changes generate no new warnings.
I have performed a self-review of my own writing and code.
I have checked my entry and corrected any misspellings.
I have made corresponding changes to the documentation if needed.
I have confirmed my changes are not being pushed from my forked main branch.
I have confirmed that I'm pushing from a new branch named after the changes I'm making.

content/javascript/concepts/number-methods/terms/isFinite/isFinite.md

yangc95 · 2021-10-08T06:24:19Z

Hi @Keshraf, nice job with these JavaScript methods!

I added some suggestions and comments. When you're finished making corrections, I'll pass this PR on to the next reviewer.

Keshraf · 2021-10-08T06:49:30Z

Hi @Keshraf, nice job with these JavaScript methods!

I added some suggestions and comments. When you're finished making corrections, I'll pass this PR on to the next reviewer.

Hii @yangc95, thank you for the suggestions.

I have made the changes please review them.

yangc95 · 2021-10-09T06:00:50Z

Hi @Keshraf, nice job with these JavaScript methods!
I added some suggestions and comments. When you're finished making corrections, I'll pass this PR on to the next reviewer.

Hii @yangc95, thank you for the suggestions.

I have made the changes please review them.

Nice, thanks for making those changes! Passing this onto @KTom101 for a second review.

sonnynomnom · 2021-10-12T20:20:02Z

Merged!

It should be live here: https://www.codecademy.com/resources/docs/javascript/number-methods/isFinite

I also made some more changes here: 1e53c9c (notably the Codebyte Example)

@Keshraf @yangc95 @KTom101

Dusch4593 · 2022-03-04T14:57:00Z

Hey @Keshraf! I'm combing through some of the entries that were added at the end of last year and noticed that the name of the contributor listed under entries such as JavaScript Number Methods: .isFinite() and .isInteger() is remarkably different from yours? (No matching email or discernible first/last name that can be gathered from either usernames)

Can you confirm that your GitHub account "Keshraf" is using the same email account as the one being used for "ramanLamichhane8756805339" on Codecademy?

Keshraf · 2022-03-04T15:00:44Z

I am not using that account on CodeAcademy.

…

On Fri, 4 Mar 2022 at 8:27 PM, Brandon Dusch ***@***.***> wrote: Hey @Keshraf <https://github.com/Keshraf>! I'm combing through some of the entries that were added at the end of last year and noticed that the name of the contributor listed under JavaScript Number Methods: isFinite() <https://www.codecademy.com/resources/docs/javascript/number-methods/isFinite> is remarkably different from yours? (No matching email or discernible first/last name that can be gathered from either usernames) Can you confirm that your GitHub account "Keshraf" is using the same email account as the one being used for "ramanLamichhane8756805339" on Codecademy? — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ2ZDEWS7V2CKWMFZJTU6IQFDANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:02:56Z

Hmmm, this is interesting. May I ask what username you use on Codecademy, if any?

Dusch4593 · 2022-03-04T15:05:34Z

It looks like all contributors are "Anonymous" on the .isNaN() entry as well (also one you initially added to Docs). I wonder if you're not logged onto Codecademy through single-sign on w/ your GitHub account?

Keshraf · 2022-03-04T15:06:40Z

This is my account on Codeacademy @ketanSaraf0066545912

…

On Fri, 4 Mar 2022 at 8:35 PM, Brandon Dusch ***@***.***> wrote: It looks like your all contributors are "Anonymous" on the .isNan() entry <https://www.codecademy.com/resources/docs/javascript/number-methods/isNaN> as well (also one you initially added to Docs). — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ7KDAMBWZHRORASFF3U6IRE7ANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:11:25Z

Cool thanks! 👍 Would you like to do the following when you have time?

Sign out of your Codecademy account completely. (but don't log off from GitHub)
Log back into Codecademy through the GitHub icon towards the bottom.

After these steps, let me know if you can see your profile credited on any of the entries mentioned. 🤞

Keshraf · 2022-03-04T15:17:06Z

Well I did sign out and log in using GitHub.

…

On Fri, 4 Mar 2022 at 8:41 PM, Brandon Dusch ***@***.***> wrote: Would you like to do the following when you have time? 1. Sign out of your Codecademy account completely. (but don't log off from GitHub) 2. Log back into Codecademy through the GitHub icon towards the bottom. After these steps, let me know if you can see your profile credited on any of the entries mentioned. 🤞 — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ3KLPPQON5FTO2F67DU6IR2VANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:19:10Z

Awesome! Can you see your profile listed on the entries now?

Dusch4593 · 2022-03-04T15:20:12Z

I can sometimes see your profile listed when I refresh. Other times not. But I think that's more of internal problem that needs sorted out on our side.

Keshraf · 2022-03-04T15:28:17Z

Where should I see my profile?

…

On Fri, 4 Mar 2022 at 8:50 PM, Brandon Dusch ***@***.***> wrote: I can sometimes see your profile listed when I refresh. Other times not. But I think that's more of internal problem that needs sorted out on our side. — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ4ETWGSACOPQU2ZKKDU6IS3TANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:32:50Z

Near the top-right under "Contributors"? Check one of the following entries:

.isFinite(): https://www.codecademy.com/resources/docs/javascript/number-methods/isFinite
.isInteger(): https://www.codecademy.com/resources/docs/javascript/number-methods/isInteger
.isNaN(): https://www.codecademy.com/resources/docs/javascript/number-methods/isNaN

Keshraf · 2022-03-04T15:34:56Z

I can’t see my profile here

…

On Fri, 4 Mar 2022 at 9:03 PM, Brandon Dusch ***@***.***> wrote: Near the top-right under "Contributors"? Check one of the following entries: - .isFinite(): https://www.codecademy.com/resources/docs/javascript/number-methods/isFinite - .isInteger(): https://www.codecademy.com/resources/docs/javascript/number-methods/isInteger - .isNan(): https://www.codecademy.com/resources/docs/javascript/number-methods/isNan — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ3N6R5UYJR7MSW3IMLU6IULJANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:37:54Z

You can't see what I'm seeing on my end (even after being logged in with GitHub)?

Keshraf · 2022-03-04T15:39:11Z

Yeah, now I can see it

…

On Fri, 4 Mar 2022 at 9:08 PM, Brandon Dusch ***@***.***> wrote: You can't see what I'm seeing on my end (even after being logged in with GitHub)? [image: Screen Shot 2022-03-04 at 10 20 29 AM] <https://user-images.githubusercontent.com/23144845/156790249-bdc18a61-b3f6-4b56-a81a-dd44f2152d2e.png> — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ7BW3NPYQSFMKXLP53U6IU6DANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T15:43:11Z

That is excellent to hear! 😃

One last thing. Did you want to stick with that default image on your Codecademy profile or change to match this cool GH profile image?

Keshraf · 2022-03-04T15:52:37Z

Matching it would be better.

…

On Fri, Mar 4, 2022 at 9:13 PM Brandon Dusch ***@***.***> wrote: That is excellent to hear! 😃 One last thing. Did you want to stick with that default image on your Codecademy profile or change to match this cool GH profile image? — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ25KWLS7XGJHP6DCDDU6IVSBANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Keshraf · 2022-03-04T15:52:43Z

Thank you for your help On Fri, Mar 4, 2022 at 9:22 PM Ketan Saraf ***@***.***> wrote:

…

Matching it would be better. On Fri, Mar 4, 2022 at 9:13 PM Brandon Dusch ***@***.***> wrote: > That is excellent to hear! 😃 > > One last thing. Did you want to stick with that default image on your > Codecademy profile or change to match this cool GH profile image? > > — > Reply to this email directly, view it on GitHub > <#344 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATSOMJ25KWLS7XGJHP6DCDDU6IVSBANCNFSM5FSG7TRQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

Dusch4593 · 2022-03-04T16:06:06Z

@Keshraf Absolute! Happy to help anytime!

Keshraf · 2022-03-04T16:07:21Z

Is there anyway, I can help you?

…

On Fri, 4 Mar 2022 at 9:36 PM, Brandon Dusch ***@***.***> wrote: @Keshraf <https://github.com/Keshraf> Absolute! Happy to help anytime! — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSOMJ6B5643GLFDGFBABTLU6IYH5ANCNFSM5FSG7TRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Dusch4593 · 2022-03-04T16:15:39Z

I think all is good on my end of things! 👍

If you're interested, there's a handful of open issues in Docs right now. I'm hoping to have more filed soon, though. 😄

Create isFinite.md

f9af24e

Keshraf mentioned this pull request Oct 7, 2021

[Entry Request] JavaScript: add isFinite() method #345

Closed

6 tasks

yangc95 added javascript JavaScript entries new entry New entry or entries labels Oct 8, 2021

yangc95 reviewed Oct 8, 2021

View reviewed changes

content/javascript/concepts/number-methods/terms/isFinite/isFinite.md Outdated Show resolved Hide resolved

yangc95 reviewed Oct 8, 2021

View reviewed changes

content/javascript/concepts/number-methods/terms/isFinite/isFinite.md Show resolved Hide resolved

Merge branch 'main' into add-isFinite-JS

489d0b2

yangc95 added the status: review 1️⃣ completed label Oct 8, 2021

Keshraf added 2 commits October 8, 2021 11:57

Update isFinite.md

599d48f

Update isFinite.md

b631d50

Keshraf requested a review from yangc95 October 8, 2021 06:49

yangc95 added 2 commits October 8, 2021 04:10

Fix commas

5d97bbc

Fix writing mechanics

0faa0d9

yangc95 approved these changes Oct 8, 2021

View reviewed changes

yangc95 requested a review from KTom101 October 8, 2021 08:16

yangc95 assigned KTom101 Oct 9, 2021

KTom101 approved these changes Oct 9, 2021

View reviewed changes

Merge branch 'main' into add-isFinite-JS

2775a5b

Dusch4593 added the status: review 2️⃣ completed label Oct 11, 2021

sonnynomnom added 2 commits October 12, 2021 01:19

Merge branch 'main' into add-isFinite-JS

84d64fe

Merge branch 'main' into add-isFinite-JS

d2cda65

sonnynomnom merged commit a9e8d05 into Codecademy:main Oct 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add isFinite.md to JavaScript #344

Add isFinite.md to JavaScript #344

Keshraf commented Oct 7, 2021 •

edited

Loading

yangc95 commented Oct 8, 2021 •

edited

Loading

Keshraf commented Oct 8, 2021

yangc95 commented Oct 9, 2021

sonnynomnom commented Oct 12, 2021

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Keshraf commented Mar 4, 2022 via email

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Add isFinite.md to JavaScript #344

Add isFinite.md to JavaScript #344

Conversation

Keshraf commented Oct 7, 2021 • edited Loading

Description

Type of Change

Checklist

yangc95 commented Oct 8, 2021 • edited Loading

Keshraf commented Oct 8, 2021

yangc95 commented Oct 9, 2021

sonnynomnom commented Oct 12, 2021

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Keshraf commented Mar 4, 2022 via email

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022

Keshraf commented Mar 4, 2022 via email

Dusch4593 commented Mar 4, 2022 • edited Loading

Keshraf commented Oct 7, 2021 •

edited

Loading

yangc95 commented Oct 8, 2021 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading

Dusch4593 commented Mar 4, 2022 •

edited

Loading