-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github API url is not necessary #27
Comments
actually, if i keep the |
Nice! |
By default, GitHub and its variants include an
GITHUB_API_URL
environment variable, so the addition ofgithub_api_url
just increased code complexity, reduced maintainability, and actually reduced flexibility since it assumeshttps://
. The latter meant I was not able to simply pass in$GITHUB_API_URL
, because it became an invalid url (e.g.,https://https://my-enterprise.url.com/api/v3
).The text was updated successfully, but these errors were encountered: