Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated labels when PR is updated #32

Open
Shudy opened this issue Oct 19, 2021 · 2 comments
Open

Duplicated labels when PR is updated #32

Shudy opened this issue Oct 19, 2021 · 2 comments
Assignees

Comments

@Shudy
Copy link

Shudy commented Oct 19, 2021

When a PR is updated with a commit and the number of modified lines changes, the GHAction applies the label to the PR, however it does not remove the old label and adds the new label of the corresponding size.

Actually the action is quite simple:

on:
  pull_request:
jobs:
  tag_pr_size:
    runs-on: ubuntu-latest
    name: Label the PR size
    steps:
      - uses: codelytv/pr-size-labeler@v1
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          xs_max_size: '10'
          s_max_size: '30'
          m_max_size: '100'
          l_max_size: '500'
          message_if_xl: >
            'This PR exceeds the recommended size of 500 lines.
            Please make sure you are NOT addressing multiple issues with one PR.’

Examples:

name: Label PR Size
Captura de pantalla 2021-10-19 a las 16 08 39

Captura de pantalla 2021-10-19 a las 16 09 04

Thanks for the work!

@rgomezcasas rgomezcasas self-assigned this Mar 20, 2022
@adrianjost
Copy link

duplicate of #19

@wpiet
Copy link

wpiet commented Aug 9, 2024

The issue with duplicated labels still occurs. Sometimes the action removes outdated label, but here is one recent example where it has not.
Is there any chance to have someone looking into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants