Skip to content

Commit

Permalink
Don't fail if missing-rules:* scripts fail
Browse files Browse the repository at this point in the history
`eslint-find-rules` currently reports deprecated rules as missing, and
so exits with a non-zero exit code.  This behavior makes the current
`missing-rules` npm script essentially useless.

For now, this adds the `—no-error` flag to all of the calls to
eslint-find-rules so that they always exit cleanly.

Once sarbbottam/eslint-find-rules#172 gets
done, we should be able to revert this change.  We could even then
include the `missing-rules` task in our CI validation suite, failing
the build if there are missing rules.
  • Loading branch information
randycoulman committed Feb 11, 2017
1 parent 4122dfb commit 4c6185b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
],
"scripts": {
"missing-rules": "run-p missing-rules:*",
"missing-rules:core": "eslint-find-rules --unused",
"missing-rules:react": "eslint-find-rules --no-core --unused react.js",
"missing-rules:react-native": "eslint-find-rules --no-core --unused react-native.js",
"missing-rules:core": "eslint-find-rules --unused --no-error",
"missing-rules:react": "eslint-find-rules --no-core --unused --no-error react.js",
"missing-rules:react-native": "eslint-find-rules --no-core --unused --no-error react-native.js",
"test": "eslint ."
},
"repository": {
Expand Down

0 comments on commit 4c6185b

Please sign in to comment.