Update eslint-config-zeal to version 0.12.0 🚀 #97
Conversation
randycoulman
force-pushed
the
greenkeeper-eslint-config-zeal-0.11.0
branch
from
39a9084 to
a8d5ccc
Compare
It turns out that eslint-plugin-react’s no `no-children-prop` has a bug when dealing with spread props, and that gets triggered in `layout/Base/index.js`. I’ve submitted a PR to that project (jsx-eslint/eslint-plugin-react#862), but for now am pointing at my PR branch. It would be possible to extract the props to a variable before passing them to `React.createElement` to work around the bug. I’m happy to go that way instead of having a github dependency in the project. Or, we could let this PR sit open for a few days to see if the PR gets merged upstream.
|
From the latest commit comment:
|
|
The above-mentioned PR has been merged, so the bug will be fixed in the next release of eslint-plugin-react. I'm inclined to hold off on merging this PR until a new release is cut. |
* Includes eslint 3.7.0, eslint-plugin-import 2.0, and babel-eslint 7.0.0
randycoulman
changed the title
# Conflicts: # package.json
|
Still no new release of eslint-plugin-react. Should we go ahead and merge this in its current state, and then update when it is released? |
|
I think we wait until eslint-plugin-react is no longer broken. This will result in bad experiences for users. |
|
It's not broken in this PR; we're just depending on my PR branch to make it not broken. I'm not sure how long it's going to be until they release a new version of eslint-plugin-react. |
| "eslint-plugin-import": "^1.13.0", | ||
| "eslint-plugin-react": "^6.1.2", | ||
| "eslint-plugin-import": "^2.0.0", | ||
| "eslint-plugin-react": "randycoulman/eslint-plugin-react#fix-spread-props-in-no-children-prop", |
There was a problem hiding this comment.
Let's point to commit merge on the master from the main repo.
Rather than referencing a potentially-transient PR branch, reference the commit where it was merged. This is still not ideal, but it’s unclear when the next release of eslint-plugin-react will happen.
Hello lovely humans,
eslint-config-zeal just published its new version 0.11.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-config-zeal.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Changed
Added
Enables warnings for new rules:
lines-around-directive,prefer-numeric-literals,symbol-description,import/no-absolute-path,react/no-children-prop,react/no-unescaped-entities,react/no-unused-prop-types, andreact/style-prop-object. (#30)Adds support for new rules, but leaves them disabled:
class-methods-use-this,line-comment-position,no-restricted-properties, andimport/max-dependencies. (#30)The new version differs by 8 commits .
dffe73cAdd PR links to changelog71d54c7Prepare 0.11.0 releasea98226fMerge pull request #30 from CodingZeal/update-dependenciesedd303eUpgrade eslint-plugin-react to 6.3.0a4a88c9Upgrade to eslint-plugin-import 1.15.0bae7e29Upgrade ESLint to v3.56c26dbcRemove old note about older ESLint versions681e66dUpgrade dev dependenciesSee the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade