Sudden shutdowns when TLS connection is ended #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcsmuller
requested review from
StefenSharkey,
HackerSmacker,
ThePedroo and
tarbomb
lcsmuller
force-pushed
the
fix/unexpected-shutdowns
branch
3 times, most recently
from
c152a3a
to
96ca44f
Compare
lcsmuller
force-pushed
the
fix/unexpected-shutdowns
branch
from
96ca44f
to
fa122d0
Compare
- Fix by changing status to `WS_DISCONNECTED` when TLS connection is ended, then avoid sending a request at `discord_gateway_perform()` by checking on the current websockets status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
is_runningflag, should checkWS Clientstatus aswell.Why?
Show-stopper bugs that would make the application crash and not be able to reconnect
How?
Change WS Client's status to
disconnectedonce the TLS connection is ended. In this case, the connection has been completely severed and the client shouldn't attempt to send more payloads to Discord's.Testing?
WIP