Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeriesSVGAnnotation wrapper for a d3.scaleTime #7

Open
johncardiologs opened this issue May 12, 2022 · 0 comments
Open

SeriesSVGAnnotation wrapper for a d3.scaleTime #7

johncardiologs opened this issue May 12, 2022 · 0 comments

Comments

@johncardiologs
Copy link

Hi Colin,

Thanks for this great project first off.

I'm trying to understand what's happening in annotation-series.js. My use case is a scatterplot that uses a scaleTime for the X axis (Y axis is a scaleLinear). For context, my xScale requires converting the data passed to it into a Date object first, and that's been working fine. I'm now trying to slap some annotations on everything but am having trouble using this seriesSVGAnnotation module to correctly position my annotations.

What are the two scales being defined in annotation-series.js and what do they have to do with your plot's main scales?

Moreover, I don't understand what fc.rebindAll is doing and how that's interacting with d3Annotation, or why we're sometimes assigning the xScale to an argument (which gets passed in where anyways?), but that might be less important.

Any insight / resources are helpful. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant