-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: ✏️ 총 지출 총합 값의 정수 범위 초과 케이스를 고려하여 타입 수정 #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...way-app-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/dto/SpendingSearchRes.java
Show resolved
Hide resolved
pennyway-app-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/dto/TargetAmountDto.java
Show resolved
Hide resolved
...way-app-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/mapper/SpendingMapper.java
Show resolved
Hide resolved
...app-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/mapper/TargetAmountMapper.java
Show resolved
Hide resolved
...ternal-api/src/main/java/kr/co/pennyway/api/apis/ledger/service/TargetAmountSaveService.java
Show resolved
Hide resolved
...p-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/usecase/TargetAmountUseCase.java
Show resolved
Hide resolved
.../src/test/java/kr/co/pennyway/api/apis/ledger/controller/TargetAmountControllerUnitTest.java
Show resolved
Hide resolved
...pi/src/test/java/kr/co/pennyway/api/apis/ledger/integration/TargetAmountIntegrationTest.java
Show resolved
Hide resolved
pennyway-app-external-api/src/test/java/kr/co/pennyway/api/config/fixture/SpendingFixture.java
Show resolved
Hide resolved
...way-domain/src/main/java/kr/co/pennyway/domain/domains/spending/dto/TotalSpendingAmount.java
Show resolved
Hide resolved
...ain/java/kr/co/pennyway/domain/domains/spending/repository/SpendingCustomRepositoryImpl.java
Show resolved
Hide resolved
...way-domain/src/main/java/kr/co/pennyway/domain/domains/spending/service/SpendingService.java
Show resolved
Hide resolved
GPT 리뷰...똑똑한데 멍청해...돈 없으니까 적당히 리뷰 해줘... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
long 타입 수정하면서, 기존에 무분별하게 원시 타입과 래퍼 타입을 혼용하던 것을 다소 보완했습니다.
long 타입을 벗어나는 경우는 고려하지 않았습니다.
현실적으로 long 타입을 벗어날 정도가 되려면
χ
개 만큼의 소비 내역이 존재해야 하는데, 이 정도면 악의적인 공격이라고 밖에 볼 수 없으며, 시스템에 큰 지장을 준다고 생각도 안 되기에 별도의 예외 처리를 하지 않았습니다.리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈
당월 목표 금액 데이터가 없으면, 총 소비내역도 확인이 불가능한 이슈가 존재함.
하지만, 해당 API는 어디까지나 "당월" 목표 금액과 총 지출 금액을 조회하려는 용도로 개발되었으며, 정상적인 플로우에서 당월 목표 금액 데이터가 존재하지 않는 경우는 없음.
따라서 해당 이슈가 ciritcal하지 않다고 판단하여, 별도로 예외처리 하지 않음.