Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permutate Topology edge IDS, not edge property mapping #144

Closed
redeboer opened this issue Jan 28, 2022 · 0 comments · Fixed by #217 or #218
Closed

Permutate Topology edge IDS, not edge property mapping #144

redeboer opened this issue Jan 28, 2022 · 0 comments · Fixed by #217 or #218
Assignees
@redeboer
Labels
🔨 Maintenance Maintenance and upkeep improvements
Milestone
0.9.8

Comments

@redeboer
Copy link
Member

The combinatorics module can probably be simplified a lot if the edge IDs of the topologies are permutated and not the keys of property mappings, like InitialFacts. Currently, functions like create_initial_facts() generate copies of InitialFacts and leave the edge IDs of the Topology the same. This is also the cause for #143.

The refactoring can be simplified with Topology.relabel_edges() (#138).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Milestone
0.9.8
1 participant
@redeboer