You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
result in the display string being: Cannot pick up {1_labelShort} Steel (no path)
The expected and correct display should be: Cannot pick up Steel (no path)
To fix this issue, the code should be modified to pass the item.LabelShort as a parameter to the Translate() method, like:
In the Core/Languages/English/Keyed/FloatMenu.xml file, the translation key for CannotPickUp is defined as:
<CannotPickUp>Cannot pick up {1_labelShort}</CannotPickUp>
This definition clearly expects a parameter to replace the {1_labelShort} placeholder. Without providing this parameter, the placeholder is displayed literally, which is not the desired outcome.
The text was updated successfully, but these errors were encountered:
Currently, the translation key is called without passing the required parameter, leading to incorrect display of the text.
the current implementation:
CombatExtended/Source/CombatExtended/Harmony/Harmony_FloatMenuMakerMap.cs
Lines 129 to 131 in d3129ed
result in the display string being:
Cannot pick up {1_labelShort} Steel (no path)
The expected and correct display should be:
Cannot pick up Steel (no path)
To fix this issue, the code should be modified to pass the item.LabelShort as a parameter to the Translate() method, like:
Reference
In the Core/Languages/English/Keyed/FloatMenu.xml file, the translation key for CannotPickUp is defined as:
This definition clearly expects a parameter to replace the {1_labelShort} placeholder. Without providing this parameter, the placeholder is displayed literally, which is not the desired outcome.
The text was updated successfully, but these errors were encountered: