Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Output names are ignored if output is a localized dataType #1863

Closed
TheToxin-git opened this issue Dec 11, 2024 · 0 comments · Fixed by #1866
Closed

[Bug]: Output names are ignored if output is a localized dataType #1863

TheToxin-git opened this issue Dec 11, 2024 · 0 comments · Fixed by #1866
Assignees
Labels
bug Something isn't working

Comments

@TheToxin-git
Copy link

TheToxin-git commented Dec 11, 2024

Frontend Version

1.5.11

Expected Behavior

1.5.10

  • ImageTile node from ComfyUI_essentials with tile_width, tile_height, overlap_x, overlap_y output names:
    image

  • Custom Group Node (LoadImage + UpscaleImageBy) with output name set to upscaled_image:
    image

Actual Behavior

1.5.11

  • ImageTile node from ComfyUI_essentials:
    1733885705_020311733
    I find this very inconvenient

  • Custom Group Node (LoadImage + UpscaleImageBy) with output name set to upscaled_image:
    image

Steps to Reproduce

Update to 1.5.11 and spawn custom / group nodes with custom output names (RETURN_NAMES)

Debug Logs

Total VRAM 11934 MB, total RAM 32010 MB
pytorch version: 2.5.1+cu124
xformers version: 0.0.28.post3
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Using xformers cross attention
Initializing frontend: Comfy-Org/ComfyUI_frontend@latest, requesting version details from GitHub...
[Prompt Server] web root: /home/thetoxin/root/downloads/github/ComfyUI/web_custom_versions/Comfy-Org_ComfyUI_frontend/1.5.11
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188

Browser Logs

Running on 127.0.0.1:8188 api.ts:167:12
ComfyUI Front-end version: 1.5.11 App.vue:30:10
unreachable code after return statement three.module.js:8173:11
load and start tracking of workflow workflows/Unsaved Workflow.json workflowStore.ts:73:12
[workflowStore] open workflow workflows/Unsaved Workflow.json workflowStore.ts:222:12

Setting JSON

{
    "Comfy.Locale": "en",
}

What browsers do you use to access the UI ?

Mozilla Firefox

Other

I believe that user should have an option to display actual RETURN_NAMES. I guess this is the culprits: #1860, #1859

Proposal — add an option under Settings > Comfy > Locale to:

  1. Force the use of RETURN_NAMES values
  2. Add a RETURN_NAME before localized type. ex. (upscaled_image | IMAGE), (tile_width | INT) and so on:
    image
@TheToxin-git TheToxin-git added the Potential Bug Untriaged bug label Dec 11, 2024
@TheToxin-git TheToxin-git changed the title [Bug]: RETURN_NAMES is being ignored, if output is a localized dataType (unsure) [Bug]: Output names are ignored, if output is a localized dataType (unsure) Dec 11, 2024
@TheToxin-git TheToxin-git changed the title [Bug]: Output names are ignored, if output is a localized dataType (unsure) [Bug]: Output names are ignored, if output is a localized dataType Dec 11, 2024
@TheToxin-git TheToxin-git changed the title [Bug]: Output names are ignored, if output is a localized dataType [Bug]: Output names are ignored if output is a localized dataType Dec 11, 2024
@huchenlei huchenlei self-assigned this Dec 11, 2024
@huchenlei huchenlei added bug Something isn't working and removed Potential Bug Untriaged bug labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants