From 2c07d2090a539904bb3e1a89a2d36ea52b7d2049 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 5 Feb 2025 19:05:00 -0800 Subject: [PATCH 1/2] Empty telemetry from front of the queue. (#838) * Empty telemetry from the front of the queue. * Fix, send miliseconds since epoch. * Fix tests. --- src/services/telemetry.ts | 4 ++-- tests/unit/telemetry.test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/services/telemetry.ts b/src/services/telemetry.ts index 24f359a0..e2e040f1 100644 --- a/src/services/telemetry.ts +++ b/src/services/telemetry.ts @@ -88,7 +88,7 @@ export class MixpanelTelemetry implements ITelemetry { track(eventName: string, properties?: PropertyDict): void { const defaultProperties = { distinct_id: this.distinctId, - time: new Date(), + time: Date.now(), $os: os.platform(), }; @@ -124,7 +124,7 @@ export class MixpanelTelemetry implements ITelemetry { */ flush(): void { while (this.queue.length > 0) { - const { eventName, properties } = this.queue.pop()!; + const { eventName, properties } = this.queue.shift()!; this.mixpanelTrack(eventName, properties); } } diff --git a/tests/unit/telemetry.test.ts b/tests/unit/telemetry.test.ts index bc27dbee..c62b7382 100644 --- a/tests/unit/telemetry.test.ts +++ b/tests/unit/telemetry.test.ts @@ -83,7 +83,7 @@ describe('MixpanelTelemetry', () => { expect(telemetry['queue'][0].properties).toMatchObject({ ...properties, distinct_id: expect.any(String), - time: expect.any(Date), + time: expect.any(Number), }); }); @@ -142,7 +142,7 @@ describe('MixpanelTelemetry', () => { properties: expect.objectContaining({ foo: 'bar', distinct_id: expect.any(String), - time: expect.any(Date), + time: expect.any(Number), }), }); }); From 494f32e344fa07ee04b7bfb23012a22e0c0bd4bb Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 5 Feb 2025 19:05:10 -0800 Subject: [PATCH 2/2] Update Manager commit (#837) Remove uv dependency for now. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 9d0a283d..6dfa50a7 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "config": { "frontendVersion": "1.8.12", "comfyVersion": "0.3.13", - "managerCommit": "1434b12c343b58a401f1c9f913965ceb0cfd089e", + "managerCommit": "b2094f773a6b04dbfa29604787b4f6b7f9ff8b81", "uvVersion": "0.5.11" }, "scripts": {