Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Scroll position resetting when using "Approve" button #470

Closed
MichaelKohler opened this issue Aug 8, 2021 · 2 comments
Closed

Scroll position resetting when using "Approve" button #470

MichaelKohler opened this issue Aug 8, 2021 · 2 comments
Labels
area: review bug Something isn't working frontend help wanted Extra attention is needed P2

Comments

@MichaelKohler
Copy link
Member

As reported to me on Matrix.

Steps to reproduce:

  • Open Sentence Collector Review Queue on Firefox for Android (Chrome needs to be tested)
  • Make sure that the full page is not visible by increasing the resolution / font size if your device is too big
  • Scroll all the way down
  • Click on the "Approve" button until you notice the viewport jumping up to the top
sc-jumping-viewport-review.mp4

So far I wasn't able to reproduce this on Desktop. I was able to reproduce this using the skip button as well. It doesn't happen every time, but often enough to be annoying.
@MichaelKohler
Copy link
Member Author

In the meantime I was also able to reproduce it on Desktop. Obviously this depends on the window size as we need to have a smaller viewport for this to happen.

@MichaelKohler MichaelKohler added the help wanted Extra attention is needed label Sep 11, 2021
MichaelKohler pushed a commit that referenced this issue Sep 18, 2021
@semantic-release-bot
chore(release): 2.11.1
cfaf448 
## [2.11.1](v2.11.0...v2.11.1) (2021-09-18)

### Bug Fixes

* design adjustments to make Review form fit better (fixes [#470](#470)) ([f428f37](f428f37))
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: review bug Something isn't working frontend help wanted Extra attention is needed P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelKohler